Fix ommer_contracts property name in application context#30
Open
oppenheim wants to merge 1 commit into
Open
Conversation
Rename ContractComponentInstance.ommer_contract to ommer_contracts so application_context_new.j2 can render sibling contract metadata in prompts. Co-authored-by: Cursor <cursoragent@cursor.com>
jtoman
approved these changes
Jun 30, 2026
|
|
||
| @property | ||
| def ommer_contract(self) -> list[ExplicitContract]: | ||
| def ommer_contracts(self) -> list[ExplicitContract]: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContractComponentInstance.ommer_contracttoommer_contractsto matchapplication_context_new.j2.application_context_new.j2(property analysis, CVL generation, property judge, Foundry, etc.).Why
application_context_new.j2referencescontext.ommer_contracts, but the Python model exposedommer_contract. Jinja resolves the missing attribute asUndefined, which is falsy, so the entire "other contracts in the application" section was silently skipped. Agents still had source tools to discover sibling contracts, but lost structured metadata (descriptions, sorts, and paths in update mode) that system analysis had already produced.Test plan
application_context_new.j2with a multi-contractContractComponentInstancenow includes the sibling contracts section.Made with Cursor