fix(rpc): add UpgradeXxHeight to Filecoin.StateGetNetworkParams#7194
Open
sudo-shashank wants to merge 10 commits into
Open
fix(rpc): add UpgradeXxHeight to Filecoin.StateGetNetworkParams#7194sudo-shashank wants to merge 10 commits into
UpgradeXxHeight to Filecoin.StateGetNetworkParams#7194sudo-shashank wants to merge 10 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds the ChangesNV29 UpgradeXxHeight Placeholder and API Filter Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
sudo-shashank
force-pushed
the
shashank/add-network-upgrade-placeholder
branch
from
33c930e to
ee96e0d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/tests/api_compare/filter-list`:
- Around line 4-6: The filter-list file currently excludes EthEstimateGas,
EthGetBlockByHash, and EthGetBlockByNumber methods with no explanation, while
these methods are fully implemented and passing conformance tests. Follow the
documentation pattern used in the filter-list-gateway file by adding comments to
each excluded method that reference the specific upstream Lotus PR or issue that
explains why the method is excluded, or alternatively remove these three methods
entirely from the filter-list if they are not actually broken in the tested
Lotus version. Each method exclusion should include a reference URL similar to
the format shown in filter-list-gateway to provide clear justification for the
exclusion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cb4ba115-6bbd-498b-bd9e-266d8995c464
⛔ Files ignored due to path filters (2)
src/rpc/snapshots/forest__rpc__tests__rpc__v0.snapis excluded by!**/*.snapsrc/rpc/snapshots/forest__rpc__tests__rpc__v1.snapis excluded by!**/*.snap
📒 Files selected for processing (11)
CHANGELOG.mddocs/openrpc-specs/v0.jsondocs/openrpc-specs/v1.jsonscripts/devnet/.envscripts/tests/api_compare/.envscripts/tests/api_compare/filter-listscripts/tests/api_compare/filter-list-gatewayscripts/tests/api_compare/filter-list-offlinescripts/tests/bootstrapper/.envscripts/tests/snapshot_parity/.envsrc/rpc/methods/state.rs
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
filecoin-project/lotus(manual)
sudo-shashank
requested review from
LesnyRumcajs and
hanabi1224
and removed request for
a team
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Follow up PR #7192
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
New Features
UpgradeXxHeightparameter, using network-specific values (mainnet vs other networks).Documentation
UpgradeXxHeight.Tests