Skip to content

Implement a desync handler dialog#69

Open
ZivDero wants to merge 9 commits into
CnCNet:mainfrom
ZivDero:desync-handler
Open

Implement a desync handler dialog#69
ZivDero wants to merge 9 commits into
CnCNet:mainfrom
ZivDero:desync-handler

Conversation

@ZivDero

@ZivDero ZivDero commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This PR replaces the "Reconnection error!" box with a dialog that lets the game continue while splitting the lobby between the desynced parties.

image

Required CSF strings:

GUI:DesyncTitle	Synchronization Error
GUI:DesyncPlayers	Players:
GUI:DesyncOutOfSync	The game has gone out of sync.
GUI:DesyncHostInfo	Press "Continue" to continue playing without the desynced players. They will continue in a separate game session.\n\nPress "Quit" to exit the game.\n\nTo go back to an earlier point, load a saved game from the CnCNet client.
GUI:DesyncWaitInfo	The host can choose for the desynced players to continue playing in separate game sessions.\n\nPlease wait while the host is making a decision.\n\nTo go back to an earlier point, load a saved game from the CnCNet client.
GUI:DesyncContinueButton	Continue
GUI:DesyncQuitButton	Quit
GUI:DesyncSendButton	Send
GUI:DesyncChatHint	Type here to chat...
GUI:DesyncStatusOK	OK
GUI:DesyncStatusDesynced	Desynced
GUI:DesyncStatusQuit	Quit

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@11EJDE11

Copy link
Copy Markdown
Member

Very cool! I can test in the next day or two.

It looks like (I haven't tested) it no longer writes the sync logs - IMO keep them.

There's some dead code - a comment mentions keeping parity with Vinifera. Not sure that's needed but up to you:

Clear_Out_Of_Sync_Data, Is_Spawner_Session, IsChatToAllies, and OutOfSyncFrame.

@ZivDero

ZivDero commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Very cool! I can test in the next day or two.

It looks like (I haven't tested) it no longer writes the sync logs - IMO keep them.

There's some dead code - a comment mentions keeping parity with Vinifera. Not sure that's needed but up to you:

Clear_Out_Of_Sync_Data, Is_Spawner_Session, IsChatToAllies, and OutOfSyncFrame.

I'll look into it - not writing logs is definitely not intended.

I'll check if some of that stuff is redundant.

@ZivDero

ZivDero commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Restored CRC logs - only vanilla though, Phobos needs to migrate its hooks. Haven't checked yet, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants