Removed trailing comma for PHP 7.1 compatibility#528
Open
girishpanchal30 wants to merge 3 commits into
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
There was a problem hiding this comment.
Pull request overview
Removes PHP 7.3-only trailing commas from wizard function calls, restoring PHP 7.1–7.2 compatibility.
Changes:
- Removes trailing commas from nested
sprintf()andwp_kses()calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
girishpanchal30
force-pushed
the
bugfix/526
branch
from
July 22, 2026 06:02
2ebbf9d to
8be83d3
Compare
Comment on lines
40
to
+71
| @@ -51,7 +59,7 @@ jobs: | |||
| - name: Setup PHP version | |||
| uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: '7.2' | |||
| php-version: ${{ matrix.php-version }} | |||
| extensions: simplexml, mysql | |||
| tools: phpunit:7.5.20, phpunit-polyfills | |||
| - name: Checkout source code | |||
| @@ -60,7 +68,7 @@ jobs: | |||
| run: sudo apt-get update && sudo apt-get install -y subversion | |||
| - name: Install WordPress Test Suite | |||
| run: | | |||
| bash bin/install-wp-tests.sh wordpress_test root root 127.0.0.1:${{ job.services.mysql.ports['3306'] }} | |||
| bash bin/install-wp-tests.sh wordpress_test root root 127.0.0.1:${{ job.services.mysql.ports['3306'] }} ${{ matrix.wp-version }} | |||
Contributor
There was a problem hiding this comment.
Not sure about the purpose of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check before Pull Request is ready:
Closes #526