Add GitHub-backed intake authentication#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cf-Access-Jwt-Assertionsignature, issuer, audience, expiry, token type, subject, and email in the WorkerPRB_API_KEYonly as a no-assertion migration fallback, with no downgrade after failed Access verificationClient safety
PRB_ACCESS_TOKENis preferred over an ambient legacy key and the client never sends bothcloudflaredlogin/token commands may print the JWTgh auth token, andGITHUB_TOKENare not accepted as intake credentialsVerification
npm test: 5 Worker authentication tests passednpm run check: Wrangler dry-run bundle passeduv run pytest -q: 222 passed, 4 skippedhttps://access-auth-intake.prb-bench.workers.dev--testupload accepted as submissionc11a6280-12c4-4517-b86b-1c48ab3c0509This PR does not deploy the version to production traffic or remove the legacy secret.