CMP-4178: Add machineset scale up after remediations applied#72
CMP-4178: Add machineset scale up after remediations applied#72Anna-Koudelkova wants to merge 1 commit into
Conversation
|
/retest |
|
|
||
| err = helpers.ValidateMachineSetScaleWithDeletePolicyNewest(tc, c, platformBindingName) | ||
| if err != nil { | ||
| t.Fatalf("MachineSet scale/deletePolicy validation failed: %s", err) |
There was a problem hiding this comment.
Should we use t.Errorf() for these error checks?
There was a problem hiding this comment.
That makes sense, thank you! I have originally used tFatalf() because the whole test cases uses it, but we probably do not need the test to fail immediately on failure in these added steps.
|
@Anna-Koudelkova: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Based on a discussion we had with Xiaojie and Taimur, it is important to keep a check that machinesets are scalable after applying remediations and the
deletePolicy: Newestwould always delete the newly added machinesets first when asked to scale down.This was previously a customer bug.