Fix subgroups#43
Merged
Merged
Conversation
cecilialau6776
requested changes
Jun 11, 2026
|
|
||
| @reconnect_on_fail | ||
| def get_members(self): | ||
| def get_members(self, uids=False): |
There was a problem hiding this comment.
Why not just make a def get_member_uids(self)? uids=False implies that uids=True will return what uids=False does but also with UIDs, not return less. At least clarify the parameter (uids_only?) and add documentation as to what it returns.
| ret.append(val) | ||
| except KeyError: | ||
| continue | ||
| if 'uid' in val[1]: |
There was a problem hiding this comment.
Flatten this block:
if 'uid' not in val[1]:
continue
val = ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes subgroups not working right, also adds ability to return uids of members instead of uids
Also the uids thing is backwards compatible
Why
it was buggy, and then getting uids is slow ):
Test Plan
python interpreter
Env Vars
nope
Documentation
haha you think we have that, (yes)
Checklist