Elig 3326 back end add batch check summary endpoint#488
Open
YiannosGeorgantas wants to merge 17 commits into
Open
Elig 3326 back end add batch check summary endpoint#488YiannosGeorgantas wants to merge 17 commits into
YiannosGeorgantas wants to merge 17 commits into
Conversation
… from the front-end (not by vendors)”
… source/user parsing helper Jim pointed us to.
Existing policy requirement: keep RequireBulkCheckScope keep RequireLaOrMatOrSchoolScope New front-end-only/source policy requirement.
Filename Status SubmittedDate SubmittedBy Outcomes dictionary
AC1: missing GUID returns 404. AC2: existing GUID returns summary. Reuses existing permission context from GetAllBulkChecksUseCase.
…n run for AC1/AC2.
… logic implementation required for AC1 and AC2.
…that does not exist returns a 404 not found.
Outcome/tier combination requirement, e.g. eligible eligible-targeted eligible-expanded notEligible
Loads bulk check Loads results Aggregates outcomes Returns required summary model.
AC1: missing bulk check returns 404 via NotFoundException. AC2: existing bulk check returns filename, status, submitted date, submitted by, and aggregated outcomes. Permission safety before result data is returned.
AC1: missing GUID returns 404.
AC2: Existing GUID returns correct summary data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No Cypress tests added following Lead guidance. Coverage added/kept at unit/API level for the summary endpoint response and not-found path.