autoclothing: don't count helms as gloves and pants#5828
Open
ab9rf wants to merge 1 commit into
Open
Conversation
also mitigate some of the worst code standard violations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autoclothingwas iterating the wrong vectors to determine fortress supply. this likely accounts for several of the assorted complaints we've received aboutautoclothingnot working reliablyalso mitigate some of the worst code standard violations, although this code still need further cleanup and i would really like to develop some sort of effective C++ idioms around the five-fold parallel types for clothing/armor for avoiding bugs of this nature in the future