scripts/add-recipe bugfixes#1591
Open
huesatlight wants to merge 7 commits into
Open
Conversation
fix the following bugs: can now add items with the same subtype number as picks. now adds digging weapons to resources.digger_type instead of weapon_type, eg: great pick when checking for procedurally generated items to exclude, use the flag instead of the adjective, which was incorrectly excluding things like "short skirt" and "large dagger". side effects: no longer adds instruments and instrument parts, but the behavior the documentation says. incidentally, the original comments said procedurally generated weapons (divine) were excluded because they weren't craftable. But they could be crafted, if they were added. This can still be done using the "single" option.
ab9rf
reviewed
Jun 11, 2026
| ## New Features | ||
|
|
||
| ## Fixes | ||
| - ``script\add-recipe``: fix to include incorrectly excluded recipes |
Member
There was a problem hiding this comment.
this should be simply add-recipe, with single backticks because it's a reference to a tool which has its own documentation page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first time using github, so feel free to correct any practices I got wrong.
add-recipe all was excluding recipes it shouldn't because of an adjective (eg: "long skirt") or because they had the same subtype number as picks. It was also including recipes the documentation says it wouldn't include (foreign instruments).