fix: dispose command when DbWrappedReader.DisposeAsync is called#2206
Open
wyf027 wants to merge 1 commit into
Open
fix: dispose command when DbWrappedReader.DisposeAsync is called#2206wyf027 wants to merge 1 commit into
wyf027 wants to merge 1 commit into
Conversation
Mirror synchronous Dispose behavior so async using with ExecuteReaderAsync releases the underlying IDbCommand. Fixes DapperLib#2185
Author
|
I checked the current PR state. There are no review comments on this PR. The only failing status is the external AppVeyor build; GitHub exposes it as a single AppVeyor failure, and the public AppVeyor API currently returns 404 for the linked build, so I cannot inspect a code-specific failure log from here. No code change made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DbWrappedReader.DisposeAsyncnow disposes the wrappedIDbCommandafter the reader, matching synchronousDisposebehavior.Motivation
Fixes #2185 —
async usingwithExecuteReaderAsyncleft the command undisposed because only the reader was disposed asynchronously.Test plan
DbWrappedReader_DisposeAsync_DisposesCommandunit test addeddotnet test tests/Dapper.Tests/Dapper.Tests.csproj --filter WrappedReaderTests