fix(realtime): correct lucy-2.5 resolution to 1280x720#7
Merged
Conversation
lucy-2.5 had inherited lucy-2.1's 1088x624 geometry. Set it to its actual 1280x720 resolution and update the model registry tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the reported resolution for the
lucy-2.5realtime model from1088×624to its actual1280×720.Why
lucy-2.5was registered withlucy-2.1's geometry, so anyone reading the model definition — or relying on it to size streams/frames — got the wrong resolution. This aligns the C++ SDK's registry with the model's real specs. Frame rate was already correct at 30fps.No public API changes; consumers using
models::realtime("lucy-2.5")automatically get the corrected width/height.