🎨 Palette: [Make Experience cards keyboard accessible]#22
Conversation
- Added `role="button"` and `tabIndex={0}` to the interactive `motion.div`.
- Added an `onKeyDown` handler to capture Enter and Space key events for navigation.
- Added `focus-visible:ring` styles to ensure visual indication during keyboard navigation.
- Fixed a TailwindCSS/Google Fonts import order warning in index.css.
- Fixed ESLint unused var definition for `motion` components.
- Fixed `__dirname` not defined issue in `vite.config.js` due to ES Module usage.
Co-authored-by: Dev22603 <92785712+Dev22603@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for dev-bachani ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
💡 What: Added keyboard accessibility to the Experience Cards on the portfolio.
🎯 Why: Previously, the cards used a
divtag acting as a button (onClick), which prevented users navigating via keyboard from selecting and interacting with the component.📸 Before/After: See the attached visual verification for the new focus rings explicitly designed for the
ExperienceCard.♿ Accessibility: Added full ARIA support (
role="button",tabIndex={0}), Enter/Space key action mappings to correctly simulate clicks, and visible focus rings (focus-visible:ring-[var(--color-primary)]).PR created automatically by Jules for task 1055001230317151566 started by @Dev22603