🎨 Palette: Add keyboard accessibility to interactive cards#27
Conversation
Added `role="button"`, `tabIndex={0}`, `onKeyDown` handlers, and `focus-visible` classes to `ExperienceCard` and `ProjectCard` to ensure users relying on keyboards can focus and interact with these elements. Also fixed minor linting and build issues in configuration files to ensure the pipeline runs cleanly.
Co-authored-by: Dev22603 <92785712+Dev22603@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for dev-bachani ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
💡 What:
Added keyboard accessibility support to interactive cards (
ExperienceCardandProjectCard) by implementingrole,tabIndex, keydown handlers (for Enter and Space keys), and clearfocus-visiblestyles using the primary color ring.🎯 Why:
The application uses
motion.divelements as clickable interactive cards for the Experience and Project sections. While mouse users could click them, these elements were invisible to keyboard navigation, making it impossible for users relying on keyboard navigation or screen readers to trigger their actions (opening modals, external links, etc.).📸 Before/After:
Before: Pressing the Tab key skipped over the interactive cards.
After: Pressing the Tab key properly focuses the cards, adding a clear
var(--color-primary)focus ring around them, and pressing Enter or Space activates theironClickhandlers. Verification screenshot has been captured via Playwright demonstrating this visual state.♿ Accessibility:
role="button"andtabIndex={0}to ensure semantic meaning and focusability.onKeyDownhandlers mapping the Enter and Space keys to their respective click actions, complete withe.preventDefault()to prevent the viewport from scrolling when the Space key is pressed.focus-visible:ring-2 focus-visible:ring-[var(--color-primary)]styles to ensure focus states meet contrast requirements against the dark background.PR created automatically by Jules for task 10952231728591113856 started by @Dev22603