🎨 Palette: Add keyboard accessibility to interactive cards#33
Conversation
Added `role="button"`, `tabIndex={0}`, keyboard event handlers, and `focus-visible` states to `ProjectCard` and `ExperienceCard` components to enable keyboard navigation. Fixed linting errors related to framer-motion and resolved Vite build configuration issues.
Co-authored-by: Dev22603 <92785712+Dev22603@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for dev-bachani ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
💡 What:
Added keyboard support to the non-native interactive components
ProjectCardandExperienceCard.🎯 Why:
These components act as buttons to open modals or follow external links, but because they are constructed with
motion.divrather than native<button>or<a>elements, they couldn't be focused via the 'Tab' key or activated via 'Enter' or 'Space'. This change enables users relying on keyboards and screen readers to interact with these elements smoothly.📸 Before/After:
ProjectCardandExperienceCardelements. No focus ring was visible.var(--color-primary)glowing ring using Tailwind'sfocus-visiblepseudo-class (preventing the ring from showing during normal mouse clicks).♿ Accessibility:
role="button"added to give screen readers proper semantics.tabIndex={0}added to include the cards in the document tab order.onKeyDownadded to simulate a click when 'Enter' or 'Space' is pressed (includinge.preventDefault()on 'Space' to prevent unwanted page scrolling).focus-visiblestyling added to maintain visual hierarchy when navigating via keyboard.PR created automatically by Jules for task 9696534159621962946 started by @Dev22603