🎨 Palette: Add keyboard accessibility to interactive cards#36
Conversation
- Added `role="button"` and `tabIndex={0}` to interactive `motion.div` containers in `ProjectCard` and `ExperienceCard`.
- Added `onKeyDown` handlers to trigger clicks on Enter and Space, preventing default scrolling behavior on Space.
- Added `focus-visible` ring styles to `ProjectCard`, `ExperienceCard`, and `BlogCard` for clear visual indicators during keyboard navigation.
- Fixed a vite build issue and linter warning regarding unused `motion` variable.
Co-authored-by: Dev22603 <92785712+Dev22603@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for dev-bachani ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
💡 What: Added proper keyboard accessibility attributes and handlers to the interactive portfolio cards (
ProjectCard,ExperienceCard,BlogCard).🎯 Why: Previously, these cards used
motion.divormotion.awithonClickhandlers but lacked keyboard interaction (Enter/Space) and focus indicators. This meant users navigating via keyboard could not activate the cards or clearly see which card was focused.📸 Before/After:
Before: Tabbing through the page skipped over or didn't visually highlight interactive cards.
After: Tabbing highlights the cards with the primary color ring, and pressing Enter or Space activates them. Verified via frontend snapshot.
♿ Accessibility:
role="button"andtabIndex={0}to non-native interactive elements.focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-primary)]for clear focus states.PR created automatically by Jules for task 12834357263075128622 started by @Dev22603