🎨 Palette: Add keyboard accessibility to ProjectCard#37
Conversation
The interactive project card component lacked keyboard navigation support. This commit adds `role="button"`, `tabIndex={0}`, an `onKeyDown` handler to respond to Enter and Space keys (preventing Space scrolling), and a `focus-visible` styling ring. It also explicitly ignores key events originating from nested native interactive elements (like the 'Source' and 'npm' links) to prevent double-triggering actions.
Co-authored-by: Dev22603 <92785712+Dev22603@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for dev-bachani ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
💡 What
Added keyboard navigation support to the
ProjectCardcomponent by addingrole="button",tabIndex={0}, a customonKeyDownevent handler, andfocus-visiblestyling.🎯 Why
The
ProjectCardcomponent uses a genericmotion.divas a clickable card surface, making it completely inaccessible to users navigating via keyboard. They were previously unable to focus or trigger the card's action to view project details or navigate to the GitHub repository.📸 Before/After
Before: The card would not receive focus when tabbing through the page.
After: The card receives a prominent primary-colored focus ring and can be triggered with
EnterorSpacewithout double-triggering nested elements.♿ Accessibility
role="button"andtabIndex={0}to surface the interactive element to screen readers.aria-labeldescribing the interactive element.onKeyDown.e.target.tagName.focus-visiblering using existing design token colors.PR created automatically by Jules for task 8804288073589103153 started by @Dev22603