🎨 Palette: Keyboard Accessibility for Interactive Cards#40
Conversation
- Added `role="button"` and `tabIndex={0}` to `ExperienceCard` and `ProjectCard` div elements.
- Implemented `onKeyDown` handlers to support 'Enter' and 'Space' activation.
- Prevented default scrolling behavior on 'Space' keypress.
- Ensured nested interactive elements (e.g. links in ProjectCard) do not double-trigger card activation by checking `e.target` in the keydown handler.
- Added `focus-visible` styling for visible keyboard focus indication.
- Included descriptive `aria-label` attributes.
- Fixed an existing ESLint config issue triggering false-positive 'motion' unused variables.
- Fixed an existing index.css CSS import order warning.
Co-authored-by: Dev22603 <92785712+Dev22603@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for dev-bachani ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
💡 What
Added full keyboard accessibility to the
ExperienceCardandProjectCardcomponents, transforming them from non-interactivedivelements into fully functional, accessible button-like interactions.🎯 Why
Previously, these card components were implemented using
motion.divwith anonClickhandler. This rendered them inaccessible to keyboard users and screen readers, as they couldn't be navigated to via theTabkey or activated usingEnterorSpace. This change ensures everyone can access the detailed views for experiences and projects.📸 Before/After
Screenshot captured in Playwright showing the new
![Focus Ring]()
focus-visiblering on the Experience card.♿ Accessibility
role="button"andtabIndex={0}to enable focus and denote functionality.onKeyDownto allow interaction viaEnterandSpacekeys (with proper event handling to prevent page scroll onSpace).ProjectCardkeydown handler to ignore events originating from nested anchor tags to prevent unintentional double-triggering.aria-labels to give screen reader users context about the action.focus-visibleutility classes to provide a clear, high-contrast focus ring that adheres to the site's primary color theme.PR created automatically by Jules for task 2673098536693846777 started by @Dev22603