🎨 Palette: [Keyboard accessibility for ProjectCard]#45
Conversation
This commit adds full keyboard accessibility to the ProjectCard component by applying appropriate ARIA roles, a tab index, and an `onKeyDown` handler to support Enter and Space interactions, as well as distinct focus-visible outlines. It also includes several critical configuration fixes for Vite, ESLint, and PostCSS to repair build and linting capabilities. Co-authored-by: Dev22603 <92785712+Dev22603@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for dev-bachani ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
💡 What: Added keyboard navigation support to the clickable
ProjectCardcomponent.🎯 Why: The component was implemented as a
motion.divwith anonClickhandler but lacked the native behaviors of an interactive element. Users navigating via keyboard could not focus on or activate the project cards, entirely breaking access to project details or external links for these users.📸 Before/After:
(See visual verification in the pre-commit review.)
♿ Accessibility:
role="button"to correctly identify the element to screen readers.tabIndex={0}to place the element within the natural document tab sequence.onKeyDownhandler listening forEnterandSpaceto trigger clicks (withe.preventDefault()on Space to stop unwanted page scrolling).<a>) key events to prevent double-firing on nested interactive elements.focus-visibleoutline styles using existing Tailwind design tokens to clearly indicate current focus state.pnpm run lintandpnpm run buildfrom succeeding).PR created automatically by Jules for task 1778812803554061805 started by @Dev22603