Skip to content

Fix pose-sensitive MoveHeldObject prompt flow#388

Merged
skywhite1024 merged 1 commit into
waicfrom
ljd/WAIC_upright_moveheldobject
Jul 13, 2026
Merged

Fix pose-sensitive MoveHeldObject prompt flow#388
skywhite1024 merged 1 commit into
waicfrom
ljd/WAIC_upright_moveheldobject

Conversation

@skywhite1024

Copy link
Copy Markdown
Collaborator

Description

This PR simplifies pose-sensitive relative placement prompts to use exactly one MoveHeldObject action that moves directly to the final release pose while applying the requested orientation. It removes the intermediate high-staging moves and updates single-arm, dual-arm, and action-pattern prompt generation accordingly.

The related prompt-generation tests now assert a five-edge graph and a single final-pose MoveHeldObject.

Dependencies: None.

Issue: Not linked.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Not applicable.

Verification

  • black --check --diff --color ./: passed (679 files unchanged)
  • 3 focused pose-sensitive prompt tests: passed
  • Broader two-file test run: 91 passed, 31 failed due to existing robot-profile, scene-geometry, and arm-mapping expectation mismatches outside this change

Checklist

  • I have run the black . equivalent check to verify formatting.
  • I have made corresponding changes to the documentation (not applicable).
  • I have added tests that prove my fix is effective.
  • Dependencies have been updated (not applicable).

@skywhite1024 skywhite1024 added agent Features related to agentic system atomic action atomic action related functionality bug Something isn't working labels Jul 13, 2026
@matafela
matafela requested review from Copilot and matafela July 13, 2026 12:26
@skywhite1024
skywhite1024 merged commit f1c837a into waic Jul 13, 2026
1 check passed
@skywhite1024
skywhite1024 deleted the ljd/WAIC_upright_moveheldobject branch July 13, 2026 12:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates pose-sensitive relative placement prompt generation so the execution-stage graph uses a single MoveHeldObject that moves directly to the final release pose while applying the requested orientation, removing prior high-staging intermediate moves. This aligns prompt text, dual-arm sequencing, and action-pattern guidance with the simplified flow and updates tests to match the new five-edge nominal graph expectation.

Changes:

  • Simplified pose-sensitive relative placement instructions and nominal step construction to remove high-staging edges and use one final-pose MoveHeldObject.
  • Updated dual-arm relative placement release edge blocks and rules to match the single final move approach.
  • Adjusted prompt-generation tests to assert a 5-edge graph and exactly one MoveHeldObject occurrence.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/gen_sim/action_agent_pipeline/test_ur5_basket_config_generation.py Updates prompt assertions to expect 5 nominal edges and a single MoveHeldObject spec for pose-sensitive placements.
tests/gen_sim/action_agent_pipeline/test_stacking_spec.py Renames and updates the pose-sensitive relative graph test to assert a single final MoveHeldObject target.
embodichain/gen_sim/action_agent_pipeline/generation/prompt_builders.py Removes high-staging prompt/edge generation for pose-sensitive relative placements and updates single/dual-arm prompt rules and action patterns accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Features related to agentic system atomic action atomic action related functionality bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants