Fix pose-sensitive MoveHeldObject prompt flow#388
Merged
Conversation
matafela
approved these changes
Jul 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates pose-sensitive relative placement prompt generation so the execution-stage graph uses a single MoveHeldObject that moves directly to the final release pose while applying the requested orientation, removing prior high-staging intermediate moves. This aligns prompt text, dual-arm sequencing, and action-pattern guidance with the simplified flow and updates tests to match the new five-edge nominal graph expectation.
Changes:
- Simplified pose-sensitive relative placement instructions and nominal step construction to remove high-staging edges and use one final-pose
MoveHeldObject. - Updated dual-arm relative placement release edge blocks and rules to match the single final move approach.
- Adjusted prompt-generation tests to assert a 5-edge graph and exactly one
MoveHeldObjectoccurrence.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/gen_sim/action_agent_pipeline/test_ur5_basket_config_generation.py | Updates prompt assertions to expect 5 nominal edges and a single MoveHeldObject spec for pose-sensitive placements. |
| tests/gen_sim/action_agent_pipeline/test_stacking_spec.py | Renames and updates the pose-sensitive relative graph test to assert a single final MoveHeldObject target. |
| embodichain/gen_sim/action_agent_pipeline/generation/prompt_builders.py | Removes high-staging prompt/edge generation for pose-sensitive relative placements and updates single/dual-arm prompt rules and action patterns accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies pose-sensitive relative placement prompts to use exactly one
MoveHeldObjectaction that moves directly to the final release pose while applying the requested orientation. It removes the intermediate high-staging moves and updates single-arm, dual-arm, and action-pattern prompt generation accordingly.The related prompt-generation tests now assert a five-edge graph and a single final-pose
MoveHeldObject.Dependencies: None.
Issue: Not linked.
Type of change
Screenshots
Not applicable.
Verification
black --check --diff --color ./: passed (679 files unchanged)Checklist
black .equivalent check to verify formatting.