Load and close PIL images with context manager when making FIB GIF#817
Open
tieneupin wants to merge 1 commit into
Open
Load and close PIL images with context manager when making FIB GIF#817tieneupin wants to merge 1 commit into
tieneupin wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=======================================
Coverage 52.39% 52.40%
=======================================
Files 98 98
Lines 10491 10493 +2
Branches 1385 1384 -1
=======================================
+ Hits 5497 5499 +2
Misses 4705 4705
Partials 289 289 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the FIB workflow has been deployed to production, we discovered that the PIL Image classes created as part of making the FIB GIFs were not closed properly, leading to too many files remaining open in memory.
This PR fixes that by ensuring that the images are opened and closed in PIL using the context manager.