Update components to new DS theme#207
Merged
VictoriaBeilsten-Edmands merged 13 commits intoJun 12, 2026
Merged
Conversation
VictoriaBeilsten-Edmands
requested review from
akademy
and removed request for
akademy
zoharma
reviewed
Jun 5, 2026
zoharma
reviewed
Jun 5, 2026
VictoriaBeilsten-Edmands
force-pushed
the
vbe/ds-theme-components
branch
4 times, most recently
from
b375210 to
b2a8d06
Compare
akademy
requested changes
Jun 8, 2026
akademy
left a comment
akademy
left a comment
Member
There was a problem hiding this comment.
I've added a few things. Also got the following questions (not about specific lines/files)
- AppTitleBar, no longer matches the NavBar colours. Is there some way to set it to the correct colours and add it as a Storybook example?
- Footer seems to have an odd background colour now. (You can see original matched the NavBar too https://diamondlightsource.github.io/sci-react-ui/?path=/docs/components-navigation-footer--docs )
- The ColourSchemeButton no longer looks cool. All the hover colours have gone. This is a sad day.
- The ColourSchemeButton also no longer matches the styling of the User control (i.e. with a filled background)
VictoriaBeilsten-Edmands
force-pushed
the
vbe/ds-theme-components
branch
2 times, most recently
from
1e1866f to
3e3611f
Compare
Collaborator
Author
|
AppTitleBar, Footer, Breadcrumbs and Navbar all use the Bar component and can use all the colours (variant + surface combinations) that are available in Bar. They have their own defaults. I've added some stories for these. The tests have been updated to pass. |
Co-authored-by: Matthew Wilcoxson <akademy@users.noreply.github.com>
VictoriaBeilsten-Edmands
force-pushed
the
vbe/ds-theme-components
branch
from
77d240e to
10107ee
Compare
zoharma
previously approved these changes
Jun 10, 2026
douglaswinter
left a comment
douglaswinter
left a comment
There was a problem hiding this comment.
The components look great across light/dark in my opinion. Just a couple of comments.
VictoriaBeilsten-Edmands
changed the base branch from
feature/diamond-ds-theme
to
main
VictoriaBeilsten-Edmands
dismissed stale reviews from douglaswinter and zoharma
The base branch was changed.
VictoriaBeilsten-Edmands
changed the base branch from
main
to
feature/diamond-ds-theme
VictoriaBeilsten-Edmands
merged commit 909e71f
into
feature/diamond-ds-theme
1 check passed
VictoriaBeilsten-Edmands
added a commit
that referenced
this pull request
Jun 12, 2026
* Update components to new DS theme * Remove multi-theme support from Storybook * Update changelog * Remove old theme and update docs * Add slot text to Bar stories Co-authored-by: Matthew Wilcoxson <akademy@users.noreply.github.com> * Update Bar and child components * Add inverse switch to ImageColourSchememSwitch * Match styling of Avatar and ColourSchemeButton * Use DiamondDS theme for tests * Remove unused sx prop from ColourSchemeButton * Add fixedTone to Logo and ImageColourSchemeSwitch * Remove args from AppTitlebar stories * Add background colour story back for ScrollableImages --------- Co-authored-by: Matthew Wilcoxson <akademy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.