ENG-1972 Improve telemetry for imports and relation creation#1178
Draft
mdroidian wants to merge 1 commit into
Draft
ENG-1972 Improve telemetry for imports and relation creation#1178mdroidian wants to merge 1 commit into
mdroidian wants to merge 1 commit into
Conversation
- Rename 'Discourse Relation: Created' to 'Discourse Relation Type: Created' for clarity - Add 'Discourse Relation Instance: Created' event after createReifiedRelation succeeds - Tracks relation instance creation from create-relation-dialog, suggestive-mode, and canvas - Includes relationUid, relationLabel, and source surface metadata - Add 'Import Dialog: Import Completed' event with node and relation counts - Add 'Import Dialog: Import Failed' event with error details - Add comprehensive telemetry event schema tests Addresses ENG-1972 Co-authored-by: Michael Gartner <mdroidian@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves telemetry for imports and relation creation to enable accurate weekly all-hands metrics reporting and clearer event tracking.
Changes
Relation Type Creation
Discourse Relation: Created→Discourse Relation Type: CreatedDiscourseRelationConfigPanel.tsxRelation Instance Creation
Discourse Relation Instance: Createdevent aftercreateReifiedRelationsucceedscreate-relation-dialog- when user creates relation via dialogsuggestive-mode- when suggestion is adoptedcanvas- when relation arrow is finalizedrelationUid- the relation type IDrelationLabel- the relation type labelsource- the surface/feature where relation was createdCreateRelationDialog.tsxSuggestionsBody.tsxDiscourseRelationUtil.tsx(added posthog import)Import Completion
Import Dialog: Import Completedevent after successful importtitle- the import titlenodeCount- number of imported nodesrelationCount- number of imported relationsImport Dialog: Import Failedevent with error detailsImportDialog.tsxTesting
apps/roam/src/utils/__tests__/telemetryEvents.test.tsImpact
Out of Scope
Stored Relations: Migration Started/CompletedTesting
Fixes ENG-1972
Linear Issue: ENG-1972