ENG-1886 Send feedback button in Obsidian by trangdoan982 · Pull Request #1181 · DiscourseGraphs/discourse-graph

trangdoan982 · 2026-06-30T22:26:50Z

https://www.loom.com/share/0c8218528a58485bbb717da9158f8745

Summary

Adds a Send feedback button to the plugin info badge in General Settings, styled to match the existing Community/Docs links
Opens a native Obsidian modal (FeedbackModal) with: screenshot attachment, email (with inline format validation), title (required), description (optional), and feedback type dropdown
On submit, POSTs to POST /api/feedback on the website, which creates a Linear triage issue and attaches any screenshot directly to the issue via Linear's file upload API
Endpoint URL is environment-driven via the existing NEXT_API_ROOT build-time injection

Test plan

Add LINEAR_API_KEY=lin_api_... to apps/website/.env
Open Obsidian settings → General → click "Send feedback" in the info badge
Verify modal opens with all fields, labels, and required indicators
Submit with an invalid email — confirm inline error appears on the field
Attach a screenshot — confirm thumbnail preview appears and can be removed
Submit valid feedback — confirm Linear triage issue is created with screenshot attached
Confirm success notice appears and modal closes

🤖 Generated with Claude Code

linear-code · 2026-06-30T22:26:53Z

ENG-1886

supabase · 2026-06-30T22:26:56Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

vercel · 2026-06-30T22:26:56Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Ready	Preview, Comment	Jun 30, 2026 11:12pm

graphite-app · 2026-06-30T22:26:56Z

PR size/scope check

This PR is over our review-size guideline.

Recommended: ~200 lines changed
Acceptable limit: up to 400 lines when well-scoped/self-contained
Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

What single problem this PR solves
Why the files/changes are coupled

devin-ai-integration

Devin Review found 6 potential issues.

Adds a "Send feedback" button to the plugin's info section that opens a modal form. Users can attach a screenshot, fill in email, title, description, and feedback type, then submit — which creates a Linear triage issue via the website API route. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Refactor feedback API helpers to use object params, declare LINEAR_API_KEY in turbo.json, and make OPTIONS sync to satisfy eslint. Co-authored-by: Cursor <cursoragent@cursor.com>

mdroidian · 2026-07-05T23:09:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46fa9d0362

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-05T23:13:09Z

+import { StrictMode, useState, useRef, useEffect } from "react";
+import type DiscourseGraphPlugin from "~/index";
+
+const FEEDBACK_ENDPOINT = `${process.env.NEXT_API_ROOT}/feedback`;


Add a production fallback for the endpoint

When the plugin is built through the documented Obsidian publish path, apps/obsidian/scripts/publish.ts invokes pnpm run build directly and the README only requires an Obsidian release token, so dbEnv.NEXT_API_ROOT is empty unless the publisher manually supplies extra env. This constant then compiles to /feedback; in Obsidian there is no website origin for that relative URL, so the new Send feedback flow fails in published builds. Please default to the production API URL or make the publish/build path set NEXT_API_ROOT.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-05T23:13:09Z

+    if (payload.screenshot) {
+      await uploadScreenshotToLinear(apiKey, issue.id, payload.screenshot);


Avoid reporting failure after creating the issue

If screenshot upload or attachment fails after createIssue succeeds, this await throws into the catch block and the API returns 500. The modal then tells the user the submission failed, but a Linear issue was already created, so retrying creates duplicate triage issues for the same feedback. Consider treating attachment failure separately or making the operation idempotent.

Useful? React with 👍 / 👎.

mdroidian

The two codex comments are worth addressing, especially the first one.

We'll need to add LINEAR_API_KEY to vercel env's, so could you create a follow-up ticket for that and tag me in it please?

Note: this makes POST /api/feedback an unauthenticated public endpoint that creates Linear tickets, with no server-side abuse mitigation.

Right now the route only checks that title is present before calling createIssue(...). The Obsidian modal has client-side email/title validation, but a bot can skip that and POST directly. CORS also does not protect this endpoint from non-browser clients.

I've created a linear ticket to further look into this, Otherwise someone can script this endpoint and flood Linear with tickets.

Right now it's fairly low risk, so I won't block on it.

mdroidian · 2026-07-06T03:29:31Z

+type FeedbackType = "feedback" | "bug_report" | "feature_request";
+
+const FEEDBACK_TYPE_LABELS: Record<FeedbackType, string> = {
+  bug_report: "Bug report",


mdroidian · 2026-07-06T03:29:35Z

+
+const FEEDBACK_TYPE_LABELS: Record<FeedbackType, string> = {
+  bug_report: "Bug report",
+  feature_request: "Feature request",


mdroidian · 2026-07-06T03:30:15Z

+        pluginVersion: plugin.manifest.version,
+      };
+
+      console.log("[FeedbackModal] POST", FEEDBACK_ENDPOINT, payload);


mdroidian · 2026-07-06T03:30:19Z

+        body: JSON.stringify(payload),
+      });
+
+      console.log("[FeedbackModal] response status:", response.status);


mdroidian · 2026-07-06T03:30:23Z

+      });
+
+      console.log("[FeedbackModal] response status:", response.status);
+      console.log("[FeedbackModal] response body:", response.json);


mdroidian · 2026-07-06T03:31:32Z

+      {/* Feedback type */}
+      <select
+        value={feedbackType}
+        onChange={(e) => setFeedbackType(e.target.value as FeedbackType)}


Why do we need to assert here?

mdroidian · 2026-07-06T03:31:36Z

+        onChange={(e) => setFeedbackType(e.target.value as FeedbackType)}
+        className={selectClass}
+      >
+        {(Object.keys(FEEDBACK_TYPE_LABELS) as FeedbackType[]).map((type) => (


Why do we need to assert here?

mdroidian · 2026-07-06T03:32:11Z

+const LINEAR_TEAM_ID = "e69757b7-976a-4567-836f-16f8a4d59df2"; // Engineering team
+const LINEAR_TRIAGE_STATE_ID = "b4d95c83-3020-4f2a-9f38-5de042c66f6b"; // Triage status
+
+type FeedbackType = "feedback" | "bug_report" | "feature_request";


vercel Bot deployed to Preview June 30, 2026 22:28 View deployment

vercel Bot temporarily deployed to Preview June 30, 2026 22:29 Inactive

devin-ai-integration Bot reviewed Jun 30, 2026

View reviewed changes

trangdoan982 force-pushed the eng-1886-send-feedback-button-in-obsidian branch from 803dfbf to f9645dd Compare June 30, 2026 22:30

vercel Bot had a problem deploying to Preview June 30, 2026 22:31 Failure

trangdoan982 force-pushed the eng-1886-send-feedback-button-in-obsidian branch from f9645dd to b0eeacb Compare June 30, 2026 22:32

vercel Bot deployed to Preview June 30, 2026 22:33 View deployment

Fix lint failures and stop prefilling email with username.

eef45ae

Refactor feedback API helpers to use object params, declare LINEAR_API_KEY in turbo.json, and make OPTIONS sync to satisfy eslint. Co-authored-by: Cursor <cursoragent@cursor.com>

vercel Bot deployed to Preview June 30, 2026 22:55 View deployment

graphite-app Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread apps/website/app/api/feedback/route.ts

add comment

46fa9d0

trangdoan982 requested a review from mdroidian June 30, 2026 23:11

vercel Bot deployed to Preview June 30, 2026 23:12 View deployment

chatgpt-codex-connector Bot reviewed Jul 5, 2026

View reviewed changes

mdroidian approved these changes Jul 6, 2026

View reviewed changes

		if (payload.screenshot) {
		await uploadScreenshotToLinear(apiKey, issue.id, payload.screenshot);

Uh oh!

Conversation

trangdoan982 commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

linear-code Bot commented Jun 30, 2026

Uh oh!

supabase Bot commented Jun 30, 2026

Uh oh!

vercel Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app Bot commented Jun 30, 2026

PR size/scope check

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdroidian commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

trangdoan982 commented Jun 30, 2026 •

edited

Loading

vercel Bot commented Jun 30, 2026 •

edited

Loading