Skip to content

ENG-1990: Restore sidebar navigation for blocks containing a smartblock #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sid597 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ENG-1990: Restore sidebar navigation for blocks containing a smartblock #1199

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae5d410
ENG-1990: Restore sidebar navigation for blocks containing a smartblock
sid597 Jul 5, 2026
a466f51
ENG-1990: Exclude all interactive elements from sidebar block navigation
sid597 Jul 6, 2026
39520f0
ENG-1990: Make rendered sidebar blocks inert except buttons
sid597 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions apps/roam/src/components/LeftSidebarView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,13 @@ const toggleFoldedState = async ({
}
};

const RoamRenderedBlock = ({ uid }: { uid: string }) => {
const RoamRenderedBlock = ({
uid,
onNavigate,
}: {
uid: string;
onNavigate: (e: React.MouseEvent) => void;
}) => {
const [version, setVersion] = useState(0);

useEffect(() => {
Expand All @@ -192,8 +198,14 @@ const RoamRenderedBlock = ({ uid }: { uid: string }) => {
};
}, [uid]);

const handleClick = (e: React.MouseEvent) => {
const target = e.target as HTMLElement;
if (target.closest("button")) return;
onNavigate(e);
Comment thread
sid597 marked this conversation as resolved.
};

return (
<div className="dg-sidebar-rendered-block">
<div className="dg-sidebar-rendered-block" onClick={handleClick}>
<RenderRoamBlock key={version} uid={uid} open={false} />
</div>
Comment thread
sid597 marked this conversation as resolved.
);
Expand All @@ -215,8 +227,11 @@ const ChildRow = ({
if (ref.type === "block" && isSmartBlockUid(ref.uid)) {
return (
<div className="pl-8 pr-2.5">
<div className="section-child-item rounded-sm leading-normal text-gray-600">
<RoamRenderedBlock uid={ref.uid} />
<div className="section-child-item cursor-pointer rounded-sm leading-normal text-gray-600">
<RoamRenderedBlock
uid={ref.uid}
onNavigate={(e) => void openTarget(e, child.text, onloadArgs)}
/>
</div>
</div>
);
Expand Down Expand Up @@ -1045,6 +1060,9 @@ export const mountLeftSidebar = async ({
.dg-sidebar-rendered-block .block-border-left { display: none; }
.dg-sidebar-rendered-block .block-ref-count-button { display: none; }
.dg-sidebar-rendered-block .rm-block-main { min-height: unset; padding: 0; }
.dg-sidebar-rendered-block * { pointer-events: none; }
.dg-sidebar-rendered-block button,
.dg-sidebar-rendered-block button * { pointer-events: auto; }
`;
document.head.appendChild(style);
}
Expand Down