ENG-1819: Make global left sidebar fold toggle personal#1200
Conversation
Fold state moves from the shared global setting to a per-user personal
setting (PERSONAL_KEYS.globalSectionFolded, legacy dual-write via a
{userUid}/Global-Section-Folded marker block). The admin Collapsable
flag is removed: the global section is now always foldable per user.
Based on prior branch commit d51649d reconciled onto current main.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c031c3c9cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review follow-up: roamAlphaAPI.user.uid() is typed string | null. With no uid the fold toggle is now session-only instead of reading/writing a marker block that every uid-less user would share.
|
Null-uid finding addressed in efcb1d6: roamAlphaAPI.user.uid() is typed string | null, so with no uid the toggle is now session-only (no marker read/write) instead of falling back to a shared "/Global-Section-Folded" marker. Note the pre-existing personal-sections code (getLeftSidebarSettings.ts, targetUserUid + "/Personal-Section") has the same degenerate case and isn't touched here. On migrating the old Global-Section > Settings > Folded state: deliberately not done. Per Michael on ENG-1819 the fold feature hasn't shipped in a release, so the old state only exists in dev graphs; the cost is a one-time default-open until re-toggled. Adding a permanent legacy fallback read for unreleased shared state (which shouldn't seed per-user prefs anyway) didn't seem worth it — happy to add if you disagree. |
|
No video because we need more than one user to test this out, we have removed the collapsable setting from the global panel. Now user can close and open directly from in the left sidebar just as the other personal left sidebar panels they have |
1 participant
Fold state of the GLOBAL sidebar section moves from the shared global setting to a per-user personal setting (PERSONAL_KEYS.globalSectionFolded, legacy dual-write via a {userUid}/Global-Section-Folded marker block, following the {userUid}/Personal-Section naming). The admin Collapsable flag is removed: the section is now always foldable, per user.
Supersedes the earlier eng-1819 branch (d51649d), reconciled onto current main; the old remote branch was replaced by this one.
Fixes ENG-1819