Skip to content

ENG-1953: Remove duplicate node alert feature#1201

Open
sid597 wants to merge 1 commit into
mainfrom
eng-1953-remove-duplicate-node-alert-on-dg-pages
Open

ENG-1953: Remove duplicate node alert feature#1201
sid597 wants to merge 1 commit into
mainfrom
eng-1953-remove-duplicate-node-alert-on-dg-pages

Conversation

@sid597

@sid597 sid597 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Removes the duplicate-node alert on DG pages end to end: the VectorDuplicateMatches component, its page-title observer wiring, the feature flag (schema, setting keys, admin panel), and the dead vector-only search wrapper in hyde.ts. The match_content_embeddings Supabase RPC stays - it is still used by discourseNodeSearchProviders. isSyncEnabled() now depends only on the suggestive mode overlay flag.

Fixes ENG-1953


Open in Devin Review

Removes VectorDuplicateMatches, its observer wiring, the feature flag
(settings schema, keys, admin panel), and the dead vector-only search
wrapper in hyde.ts. The match_content_embeddings RPC stays: it is
still used by discourseNodeSearchProviders.
@linear-code

linear-code Bot commented Jul 6, 2026

Copy link
Copy Markdown

ENG-1953

@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Jul 6, 2026 7:43am

Request Review

@graphite-app

graphite-app Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@supabase

supabase Bot commented Jul 6, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread apps/roam/src/components/settings/utils/settingKeys.ts
@sid597

sid597 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

The FEATURE_FLAG_KEYS gap for "Advanced node search enabled" is real but pre-existing (as the review notes) and unrelated to this removal, so it's not fixed here — filed ENG-2001 to track it.

@sid597 sid597 requested a review from mdroidian July 6, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant