docs: add Figma design links and real Badges to Storybook toolbar#1076
Open
frankieyan wants to merge 11 commits into
Open
docs: add Figma design links and real Badges to Storybook toolbar#1076frankieyan wants to merge 11 commits into
frankieyan wants to merge 11 commits into
Conversation
cc7ad5e to
8d750c2
Compare
doistbot
reviewed
Jun 18, 2026
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR adds Figma design links to the Storybook toolbar for most component stories and switches the a11y/deprecated badges to use the real Reactist <Badge> component.
Few things worth tightening:
- The Figma tool shows a "No Figma link" message on docs pages that define their own MDX
<Meta>(e.g.modal-docs.mdx) instead of inheriting story meta—consider hiding the tool when there are no links, or wiringfigmainto those docs pages. VALID_TONESduplicates the Badge component's tone list as a second source of truth; exporting a runtime tone list or validator from the badge module and reusing it here would prevent valid badges from silently disappearing if tones change.- The bare-string branch in the Figma parameter resolver treats any non-empty string as both label and URL, turning typos into broken links—since all current usages already use
{ label, url }, dropping the string shorthand would keep the parameter shape explicit. IconButton(which always wraps in aTooltipand pulls@ariakit/reactinto the manager bundle) is heavier than needed for a simple external link in the Storybook manager; a lightweight<a>or button with a nativetitlewould reduce startup overhead on every page.
I also included a few optional follow-up notes in the details below.
Optional follow-up note (1)
- [P3] .storybook/figma/figma-tool.tsx:23:
IconButtonis pretty expensive in manager UI. In this code path it always wraps itself inTooltip(tooltip={link.label}), which pulls@ariakit/reactinto the Storybook manager bundle and creates a tooltip store for each Figma link. Becausemanager.tsloads on every Storybook page, this adds avoidable startup and render overhead for a simple external link. A lightweight<a>/button here with a nativetitlewould keep the manager much smaller.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
2fd229b to
7248209
Compare
7248209 to
baef499
Compare
baef499 to
a3dd4b2
Compare
nats12
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds Figma references to most of our component stories in the Storybook toolbar, sourced from https://github.com/Doist/frontend-issues/issues/1350.
We also switch the a11y/deprecated badges in the toolbar to use the real Reactist
<Badge>.PR Checklist
Demo