Refactoring goals#504
Closed
vcharraut wants to merge 9 commits into
Closed
Conversation
…ry observation feature count
…; streamline interactive replay payload handling
…just spacing parameters
…vironment metrics
Collaborator
Author
|
Split into two stacked PRs for reviewability:
Superseded by those; can be closed once #511/#512 are reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rewrites the target/waypoint system into a single, direct goal abstraction.
Removed the intermediate
Path/Waypointlayer:struct Path,struct Waypoint,MAX_NUM_WP_PATH(200-point densification),build_path,get_closest_waypoint_index_on_path,path_progression,closest_path_idx_wp,num_waypoints_reached.New goal model (
datatypes.h):list_goal_{x,y,z}[MAX_GOALS]+list_goal_lane[], withcurrent_goal_*aliases,goal_count, andgt_goal_*(ground-truth goal pin for replay).Agent.current_route_index→current_route_idx.New generation / regeneration pipeline (
drive.h):chain_goals→commit_goals,generate_new_goals_from_route,generate_new_goals_from_map,roll_goals,route_point_at_distance,compute_new_route.Lane-graph GPS distance:
LaneGraph.lane_to_graph_idx(road-element idx → graph idx) enables appending normalized lane-graph distance-to-goal on lane obs rows.Config (
drive.ini/env_config.h) — renamed/replaced:target_type(static/dynamic) →goal_regen_mode(finite= regen full set once all reached /rolling= sliding window).goal_on_lane→goal_source(route= agent forward route /map= uniform free-roam).num_target_waypoints→num_goals;min/max_waypoint_spacing→min/max_goal_spacing.obs_goal_lane_distanceflag.Lane/boundary observation unpacking capped to the first 7 elements per row; obs feature counts adjusted accordingly. Notebooks,
viz.py,torch.py, tests, and rollout/smoke golden data updated to match.🤖 Generated with Claude Code