Prevent invalid command casing from starting cooldowns - #6597
Open
Guflly wants to merge 1 commit into
Open
Conversation
Guflly
marked this pull request as ready for review
July 27, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #5915.
Details
Proposed fix:
Preserve the command label as entered and verify that it is registered before expanding formatted aliases or applying command cooldowns. Valid lowercase aliases continue to resolve to their canonical command for cooldown matching, while invalid case variants no longer start a cooldown. The existing case-insensitive behavior is retained for pre-flattening server versions.
Environments tested:
OS: Windows 11
Java version: 21.0.10
Demonstration:
Added regression tests confirming that
/EFEEDdoes not start a cooldown when that case variant is not registered and/efeedstill applies the canonicalfeedcooldown.Validation:
.\gradlew.bat :EssentialsX:test --tests com.earth2me.essentials.EssentialsPlayerListenerTest --console=plain.\gradlew.bat :EssentialsX:checkstyleMain :EssentialsX:checkstyleTest --console=plainBoth commands completed successfully. The focused suite passed 2 tests with no failures, errors, or skipped tests.