[pull] master from beyond-all-reason:master#27
Merged
Conversation
str() was defined inline in the headers, which forced <format> onto every translation unit that includes float3.h - i.e. most of the engine, plus vendored targets (lua, luasocket) that pull it in transitively. That is a lot of compile-time cost for a debug-only helper, and it means any target touching float3.h must have the formatting library's headers available. Move the three str() bodies into their .cpp files and drop <format> from the headers (float3.h keeps <string> for the declaration). Now only the three math .cpp files need <format>. Add the direct <format> include to the two other live std::format users that were relying on the transitive pull (UnsyncedGameCommands.cpp, DumpHistory.cpp).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )