fix(tilt): drop faf-ws-bridge reference#319
Conversation
faf-python-server now speaks WebSocket directly on 8003/ws, so the
ws_bridge_rs sidecar is no longer needed.
- Point the IngressRoute for ws.{baseDomain} at faf-lobby-server:8003
instead of faf-ws-bridge:8003 (and rename the resource).
- Remove the LISTEN block from the lobby config; the new server reads
WS_HOST/WS_PORT/WS_PATH and the defaults already produce :8003/ws.
- Set WS_FORWARDED_IP_HEADER=CF-Connecting-IP so the real client IP
from Cloudflare is preserved.
- Bump image to faforever/faf-python-server:feature-websocket for the
test deploy.
- Delete apps/faf-ws-bridge entirely.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The chart was removed in bfc1c73 but the Tiltfile still referenced it, breaking `Test Using Local Config` with: Error in fail: No objects found for chart apps/faf-ws-bridge Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoves the ChangesRemove faf-ws-bridge Tilt wiring
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
bfc1c73 feat(lobby): use native WebSocket, drop faf-ws-bridgedeletedapps/faf-ws-bridge/but left theproxy_local_service_if_set(... service_chart="apps/faf-ws-bridge" ...)block in theTiltfile. That broke develop'sTest Using Local Configcheck with:This drops the dead block.
Test plan
Tiltfileno longer referencesfaf-ws-bridgeTest Using Local Configto go green on this branch🤖 Generated with Claude Code
Summary by CodeRabbit