Skip to content

fix(tilt): drop faf-ws-bridge reference#319

Closed
Brutus5000 wants to merge 2 commits into
developfrom
fix/drop-ws-bridge-tiltfile
Closed

fix(tilt): drop faf-ws-bridge reference#319
Brutus5000 wants to merge 2 commits into
developfrom
fix/drop-ws-bridge-tiltfile

Conversation

@Brutus5000

@Brutus5000 Brutus5000 commented Jun 14, 2026

Copy link
Copy Markdown
Member

Summary

bfc1c73 feat(lobby): use native WebSocket, drop faf-ws-bridge deleted apps/faf-ws-bridge/ but left the proxy_local_service_if_set(... service_chart="apps/faf-ws-bridge" ...) block in the Tiltfile. That broke develop's Test Using Local Config check with:

Error in fail: No objects found for chart apps/faf-ws-bridge

This drops the dead block.

Test plan

  • Tiltfile no longer references faf-ws-bridge
  • Wait for Test Using Local Config to go green on this branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Simplified development infrastructure configuration by removing an intermediate proxy service component. This streamlines the local development setup process.

Brutus5000 and others added 2 commits June 14, 2026 10:35
faf-python-server now speaks WebSocket directly on 8003/ws, so the
ws_bridge_rs sidecar is no longer needed.

- Point the IngressRoute for ws.{baseDomain} at faf-lobby-server:8003
  instead of faf-ws-bridge:8003 (and rename the resource).
- Remove the LISTEN block from the lobby config; the new server reads
  WS_HOST/WS_PORT/WS_PATH and the defaults already produce :8003/ws.
- Set WS_FORWARDED_IP_HEADER=CF-Connecting-IP so the real client IP
  from Cloudflare is preserved.
- Bump image to faforever/faf-python-server:feature-websocket for the
  test deploy.
- Delete apps/faf-ws-bridge entirely.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The chart was removed in bfc1c73 but the Tiltfile still referenced it,
breaking `Test Using Local Config` with:

  Error in fail: No objects found for chart apps/faf-ws-bridge

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a15bc41-29c3-4a29-b941-7d9c279d1450

📥 Commits

Reviewing files that changed from the base of the PR and between bfc1c73 and 6a2de78.

📒 Files selected for processing (1)
  • Tiltfile
💤 Files with no reviewable changes (1)
  • Tiltfile

📝 Walkthrough

Walkthrough

Removes the faf-ws-bridge service block from the Tiltfile. The deleted lines declared lobby-related dependencies and labels for ws_bridge and called proxy_local_service_if_set for apps/faf-ws-bridge. Configuration now proceeds directly to faf-icebreaker setup.

Changes

Remove faf-ws-bridge Tilt wiring

Layer / File(s) Summary
Delete faf-ws-bridge proxy service block
Tiltfile
Removes the four-line block declaring ws_bridge deps/labels and invoking proxy_local_service_if_set for apps/faf-ws-bridge.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bridge once crossed the lobby's stream,
Four lines removed — or so it seems.
The Tiltfile hops along with cheer,
No ws-bridge to engineer.
🐇 On to icebreaker we go!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(tilt): drop faf-ws-bridge reference' accurately reflects the main change: removing an orphaned faf-ws-bridge reference from the Tiltfile configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/drop-ws-bridge-tiltfile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Brutus5000 Brutus5000 closed this Jun 14, 2026
@Brutus5000 Brutus5000 deleted the fix/drop-ws-bridge-tiltfile branch June 14, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant