Skip to content

Moving non-deterministic info line to debug output#1632

Open
kholoimov wants to merge 1 commit into
FairRootGroup:masterfrom
kholoimov:dev_vkholoimov_FairLogger_changes
Open

Moving non-deterministic info line to debug output#1632
kholoimov wants to merge 1 commit into
FairRootGroup:masterfrom
kholoimov:dev_vkholoimov_FairLogger_changes

Conversation

@kholoimov

Copy link
Copy Markdown

This PR moves the branch-address log from info to debug.

That output includes a raw pointer address, which is not deterministic across runs because it depends on runtime memory layout. Because of that, the logs are not deterministic even when the simulation result is the same. This makes automatic testing by direct log comparison difficult unless the output is cleaned up first.
It also exposes low-level technical detail that is mainly useful for debugging, not for normal simulation logs.

We want to make this change to keep FairShip output cleaner and more deterministic for testing.


Checklist:

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9bb4da76-2515-4bce-a470-2cbd1b6f38cb

📥 Commits

Reviewing files that changed from the base of the PR and between 5863027 and 4e38dd3.

📒 Files selected for processing (1)
  • fairroot/base/sink/FairRootFileSink.cxx

📝 Walkthrough

Walkthrough

A single logging statement in FairRootFileSink::CreatePersistentBranchesAny is downgraded from info-level to debug-level verbosity during persistent ROOT branch creation.

Changes

Logging Adjustment

Layer / File(s) Summary
Persistent branch creation log level
fairroot/base/sink/FairRootFileSink.cxx
Per-branch log statement for persistent ROOT branch creation downgraded from LOG(info) to LOG(debug).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: moving a non-deterministic logging line from info to debug level.
Description check ✅ Passed The description provides relevant context about why the change is needed, explaining the non-deterministic pointer addresses and testing implications.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant