Skip to content

Add support for uncompressing .tar.xz archives - #597

Open
ITaluone wants to merge 1 commit into
Fallout-build:mainfrom
ITaluone:feat/tar-xz-support
Open

Add support for uncompressing .tar.xz archives#597
ITaluone wants to merge 1 commit into
Fallout-build:mainfrom
ITaluone:feat/tar-xz-support

Conversation

@ITaluone

@ITaluone ITaluone commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What changed

  • Add UnTarXzTo extension on AbsolutePath, using SharpCompress.Readers.ReaderFactory to extract .tar.xz/.txz archives.
  • Wire it into UncompressTo alongside the existing zip/tar.gz/tar.bz2 branches.
  • Compressing to .tar.xz stays unsupported (CompressTo still fails fast with a clear message) — this PR only adds the read path.
  • Add the SharpCompress package reference to Fallout.Utilities.IO.Compression.

Verification

Manual Target which runs this extension

Drawback

Compressing .tar.xz files does not work, since the upstream lib also can't do this.

Closes: #596

@ITaluone
ITaluone requested a review from a team as a code owner July 29, 2026 06:33
@ITaluone ITaluone linked an issue Jul 29, 2026 that may be closed by this pull request
Fallout (and also former NUKE) lacks of possibility to uncompress a .tar.xz archive #596
Open
@ITaluone

ITaluone commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@dennisdoomen This should look familiar to you (did the same thing in FA.. this whole nodejs thing ;) )

@ITaluone ITaluone added enhancement New feature or request target/vCurrent Targets the current version labels Jul 29, 2026
@ChrisonSimtian ChrisonSimtian added target/vNext Targets the next calendar-version and removed target/vCurrent Targets the current version labels Jul 30, 2026
@ChrisonSimtian

ChrisonSimtian commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

@ITaluone i wanna bring in some more discipline, can you create an issue for that please and describe the use case we're trying to solve here?
I love the enthusiasm of adding new features but I think we should go the extra mile and help people understand why they want this feature :-)
Probably also needs some docs (which can be a dedicated PR linking to the same issue ;-) see how this becomes a shoe? :D )

And then I'd say lets target this for the next release, not the current one. I wanna close the lid on this one (already relabelled)

ChrisonSimtian
ChrisonSimtian reviewed Jul 30, 2026
View reviewed changes
Comment thread Directory.Packages.props
@ITaluone

ITaluone commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@ITaluone i wanna bring in some more discipline, can you create an issue for that please and describe the use case we're trying to solve here? I love the enthusiasm of adding new features but I think we should go the extra mile and help people understand why they want this feature :-) Probably also needs some docs (which can be a dedicated PR linking to the same issue ;-) see how this becomes a shoe? :D )

And then I'd say lets target this for the next release, not the current one. I wanna close the lid on this one (already relabelled)

@ChrisonSimtian
I don't get it? there is an issue already? Or isn't the issue detailed enough?

@ITaluone
ITaluone requested a review from ChrisonSimtian July 30, 2026 05:33
@ITaluone ITaluone mentioned this pull request Jul 30, 2026
Open
dennisdoomen
dennisdoomen requested changes Aug 1, 2026
View reviewed changes
Comment thread src/Fallout.Utilities.IO.Compression/CompressionExtensions.cs
using SharpCompress.Readers;
using Fallout.Common.Utilities.Collections;

namespace Fallout.Common.IO;

@dennisdoomen dennisdoomen Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 (required) Please also do an auto-cleanup with Rider or R# so we improve the layout of existing files gradually.

Comment thread src/Fallout.Utilities.IO.Compression/CompressionExtensions.cs
UncompressTar(archiveFile, directory, x => new BZip2InputStream(x));
}

public static void UnTarXzTo(this AbsolutePath archive, AbsolutePath directory)

@dennisdoomen dennisdoomen Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 We need to be more rigid on the documentation side, something Nuke really lacked. I'm expecting some XML docs on what does method does, which extensions it supports, what happens if directory doesn't exist, what happens if directory contains conflicting files, etc.

Comment thread src/Fallout.Utilities.IO.Compression/Fallout.Utilities.IO.Compression.csproj

<ItemGroup>
<PackageReference Include="SharpZipLib" />
<PackageReference Include="SharpCompress" />

@dennisdoomen dennisdoomen Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisonSimtian do you see a concern with this extra dependency? I don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen requested changes
@ChrisonSimtian ChrisonSimtian Awaiting requested review from ChrisonSimtian

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request target/vNext Targets the next calendar-version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fallout (and also former NUKE) lacks of possibility to uncompress a .tar.xz archive

3 participants

@ITaluone @ChrisonSimtian @dennisdoomen