Translate base64 name-decode errors to StreamReadException#882
Open
Sahana2524 wants to merge 2 commits into
Open
Translate base64 name-decode errors to StreamReadException#882Sahana2524 wants to merge 2 commits into
StreamReadException#882Sahana2524 wants to merge 2 commits into
Conversation
Member
|
Test makes sense and problem should be addressed. But not in "nextToken()" calls -- needs to be closer to the actual fail, NameProcessor must translate failures and not leak them through. |
Contributor
Author
|
Makes sense. Moved the translation into the base64 processors themselves: |
StreamReadException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a base64
XmlNameProcessoris configured, reading a name that is not valid base64 lets the decoder's exception escape the parser:The base64 processors decode every incoming element/attribute name through
java.util.Base64, which throwsIllegalArgumentExceptionon malformed input. That went uncaught, so callers guarding reads withcatch (JacksonException)see a raw runtime exception instead.The base64 processors in
XmlNameProcessorsnow translate the decoder'sIllegalArgumentExceptioninto aStreamReadExceptionat the point of decode, so the failure is handled where it happens and cannot leak through any parser path (root-name decode inXmlTokenStream.initialize()or later names in_nextToken()). Valid names and the default passthrough processor are unchanged. Added regression tests inXmlNameEscapeTestfor both the prefixed and always-on base64 processors.