fix(Change Requests): Revamp docs, improve UX by emyller · Pull Request #7709 · Flagsmith/flagsmith

emyller · 2026-06-04T18:33:58Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Rogue PR resulting from customer support work.

Improves UI around feature overrides
Disambiguates feature and segment change requests
Rewrite change requests docs
Adds missing permissions to RBAC docs

How did you test this code?

Manually checked visual changes, and you can too:

New documentation: https://docs-git-fix-segment-change-requests-docs-ux-flagsmith.vercel.app/administration-and-security/governance-and-compliance/change-requests

UI screenshots:

Before:

After:

Before:

After — contains some extra UI unrelated with changes:

vercel · 2026-06-04T18:34:04Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview, Comment	Jun 8, 2026 1:09pm
flagsmith-frontend-preview	Ready	Preview, Comment	Jun 8, 2026 1:09pm
flagsmith-frontend-staging	Ready	Preview, Comment	Jun 8, 2026 1:09pm

…quests-docs-ux

github-actions · 2026-06-04T18:43:37Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api-test:pr-7709`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-e2e:pr-7709`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-7709`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7709`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7709`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-7709`	Finished ✅	Results ✅

codecov · 2026-06-04T18:49:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.52%. Comparing base (cbcac64) to head (88a4ecf).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7709   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files        1444     1444           
  Lines       54971    54971           
=======================================
  Hits        54161    54161           
  Misses        810      810

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The uv bump in #7708 changed tool.uv.required-version from a pinned "0.11.14" to a range ">=0.11.18". The install-uv Make target derived UV_VERSION via lstrip("="), which leaves the ">=" prefix intact and produces the invalid pip requirement "uv==>=0.11.18", failing every API image build. Strip leading comparator characters so the derived version is a bare "0.11.18". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

github-actions · 2026-06-04T19:13:59Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
35.1 seconds
88a4ecf
🔄 Run: #17262 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
45.3 seconds
88a4ecf
🔄 Run: #17262 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
44.2 seconds
88a4ecf
🔄 Run: #17262 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
1 minute, 6 seconds
88a4ecf
🔄 Run: #17262 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
40.7 seconds
3b5e2a7
🔄 Run: #17340 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

19 passed

Details

19 tests across 15 suites
1 minute, 7 seconds
3b5e2a7
🔄 Run: #17340 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
43.9 seconds
3b5e2a7
🔄 Run: #17340 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
35.1 seconds
3b5e2a7
🔄 Run: #17340 (attempt 1)

github-actions · 2026-06-04T19:15:20Z

Visual Regression

19 screenshots compared. See report for details.
View full report

matthewelwell · 2026-06-08T08:26:52Z

/gemini review

gemini-code-assist

Code Review

This pull request updates the documentation and frontend UI to clearly distinguish between 'Feature Change Requests' (environment-level) and 'Segment Change Requests' (project-level). It renames various UI labels, updates the RBAC and Change Requests documentation, refactors the Identity and Segment Overrides tabs to improve layout and clarify behavior, and replaces '4-eyes' terminology with 'four-eyes'. Additionally, it updates the uv package manager's required version specification in the API configuration. There are no review comments, and I have no feedback to provide.

…quests-docs-ux

Zaimwa9

Overall looks good to me. Most of my comments are NIT, I let you decide if they are worth.
I'd just push back on removing the collapsible note for Identity override InfoMessage (which is a nit too I agree). Ideally it would be dismissable

Zaimwa9 · 2026-06-09T12:29:15Z

          {!showCreateSegment && (
            <div>
+              <p className='text-right mt-4 fs-small lh-sm modal-caption'>
+                Drag overrides to adjust priority.


NIT and not 100% convinced but proposing :)

Suggested change

Drag overrides to adjust priority.

Re-order overrides to adjust priority.

Zaimwa9 · 2026-06-09T12:33:56Z

-| Feature state type  | Scoped to                       | Requires a Change Request? |
-| ------------------- | ------------------------------- | -------------------------- |
-| Environment default | All users in an environment     | ✅ Yes                     |
-| Segment override    | Users matching a segment        | ✅ Yes                     |
-| Identity override   | A single specific identity      | ❌ No — live immediately   |


Are we sure we want to completely get rid of this part ? Or maybe should we mention that identity override are live immediately ?

Zaimwa9 · 2026-06-09T12:38:48Z

+              >
+                Learn more
+              </a>
+            </p>{' '}


Suggested change

</p>{' '}

</p>

Zaimwa9 · 2026-06-09T12:39:53Z

+            Learn more
+          </a>
+        </div>
+        <InfoMessage>


I think it needs the collapseId like here to be collapsable, except if that was intentional ? https://github.com/Flagsmith/flagsmith/pull/7709/changes#diff-856506891655aee9290f3dd8ed40cc093a5a57d53942d1bfb1c76f35eae75786L178

Yes confirmed here

talissoncosta · 2026-06-09T11:40:22Z

+              title={
+                <h5 className='mb-0'>
+                  Identity Overrides{' '}
+                  <Icon name='info-outlined' width={20} fill='#9DA4AE' />


Can you please check if this fill + color is really needed?

talissoncosta · 2026-06-09T12:17:57Z

  }
 }

-.segment-overrides-title {


We still reference this class on SegmentOverridesTab.tsx:141 (the <Row>), and it'll be style-less once this rule goes. This is safe to drop there too and avoid leaving an orphan. You already cleaned up identity-overrides-title nicely, this is just the last one.

emyller added 8 commits June 3, 2026 19:57

Allow the future

54021ac

Improve UI and wording around Identity and Segment Overrides

2fd6cfe

Fix button position

d8869eb

Four

ae34b81

Update Change Request menu names

ae1a6af

Refactor feature change request docs

1c14ebe

Add missing permissions to docs

398d08e

Add segment change requests docs

e76da59

github-actions Bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API docs Documentation updates labels Jun 4, 2026

emyller changed the title ~~Fix/segment change requests docs ux~~ fix(Change Requests): Revamp docs, improve UX Jun 4, 2026

Merge remote-tracking branch 'github/main' into fix/segment-change-re…

65c106c

…quests-docs-ux

emyller marked this pull request as ready for review June 4, 2026 18:42

emyller requested review from a team as code owners June 4, 2026 18:42

emyller requested review from Holmus, khvn26 and kyle-ssg and removed request for a team June 4, 2026 18:42

flagsmith-engineering Bot assigned Holmus, kyle-ssg and khvn26 Jun 4, 2026

vercel Bot deployed to Preview – flagsmith-frontend-preview June 4, 2026 18:42 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging June 4, 2026 18:42 View deployment

github-actions Bot removed the docs Documentation updates label Jun 4, 2026

github-actions Bot added docs Documentation updates fix and removed fix docs Documentation updates labels Jun 4, 2026

emyller assigned emyller and talissoncosta and unassigned khvn26, Holmus and kyle-ssg Jun 5, 2026

gemini-code-assist Bot reviewed Jun 8, 2026

View reviewed changes

Merge remote-tracking branch 'github/main' into fix/segment-change-re…

3b5e2a7

…quests-docs-ux

github-actions Bot added the docs Documentation updates label Jun 8, 2026

vercel Bot deployed to Preview – docs June 8, 2026 13:09 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging June 8, 2026 13:09 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview June 8, 2026 13:09 View deployment

github-actions Bot added fix and removed fix docs Documentation updates labels Jun 8, 2026

Zaimwa9 requested changes Jun 9, 2026

View reviewed changes

Zaimwa9 removed request for khvn26 and kyle-ssg June 9, 2026 12:44

talissoncosta reviewed Jun 9, 2026

View reviewed changes

talissoncosta assigned Zaimwa9 and unassigned talissoncosta Jun 9, 2026

	Drag overrides to adjust priority.
	Re-order overrides to adjust priority.

Conversation

emyller commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

vercel Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

codecov Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Uh oh!

github-actions Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

matthewelwell commented Jun 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Zaimwa9 left a comment

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

emyller commented Jun 4, 2026 •

edited

Loading

vercel Bot commented Jun 4, 2026 •

edited

Loading

github-actions Bot commented Jun 4, 2026 •

edited

Loading

codecov Bot commented Jun 4, 2026 •

edited

Loading

github-actions Bot commented Jun 4, 2026 •

edited

Loading

github-actions Bot commented Jun 4, 2026 •

edited

Loading