Skip to content

Reject string covariance feature control scalars #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlorianPfaff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject string covariance feature control scalars #3656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pyrecest/utils/pairwise_covariance_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ def _validate_control_scalar(value: Any, name: str, *, allow_zero: bool) -> floa

if isinstance(scalar_value, bool):
raise ValueError(f"{name} must be numeric, not boolean")
if isinstance(scalar_value, (str, bytes, bytearray)):
raise ValueError(f"{name} must be numeric")

try:
value_float = float(scalar_value)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_pairwise_covariance_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def test_pairwise_mahalanobis_distances_rejects_ambiguous_regularization(self):
means = array([[0.0], [0.0]])
covariance = zeros((2, 2, 1))

for bad_regularization in (True, array([1.0])):
for bad_regularization in (True, "1.0", b"1.0", array([1.0])):
with self.subTest(bad_regularization=bad_regularization):
with self.assertRaisesRegex(ValueError, "regularization"):
pairwise_mahalanobis_distances(
Expand Down Expand Up @@ -134,7 +134,7 @@ def test_pairwise_covariance_shape_components_support_empty_stacks(self):
def test_pairwise_covariance_shape_components_rejects_ambiguous_epsilon(self):
covariances = zeros((2, 2, 1))

for bad_epsilon in (True, array([1e-6])):
for bad_epsilon in (True, "1e-6", b"1e-6", array([1e-6])):
with self.subTest(bad_epsilon=bad_epsilon):
with self.assertRaisesRegex(ValueError, "epsilon"):
pairwise_covariance_shape_components(
Expand Down
Loading