Skip to content

Honor forced pairs in Murty subproblems#3689

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-murty-forced-prefix
Open

Honor forced pairs in Murty subproblems#3689
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-murty-forced-prefix

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • make Murty child subproblems actually enforce their forced prefix row/column pairs
  • reject contradictory forced/forbidden pairs before solving a child subproblem
  • add a regression covering duplicate k-best assignment output from an ignored forced prefix

Bug fixed

murty_k_best_assignments() records a forced prefix when branching, but _solve_subproblem() only checked for duplicate forced rows/columns and then restored the forced cell. It did not mask the rest of the forced row and column, so the linear assignment solver could ignore the forced prefix. On tied/near-tied partial-assignment cases this could repeat an earlier assignment and skip a valid next-best alternative.

Testing

  • Added tests/utils/test_assignment_murty_forced_prefix.py.
  • Inspected main..fix-murty-forced-prefix: 2 files changed, +40/-1.
  • Full test suite not run locally; this environment cannot resolve github.com for cloning/installing the repo.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 51.02s
✅ JSON prettier 7 0 0 0 0.94s
✅ JSON v8r 7 0 0 3.85s
✅ MARKDOWN markdownlint 68 0 0 0 1.25s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.51s
✅ PYTHON black 1201 34 0 0 48.71s
✅ PYTHON isort 1201 65 0 0 2.59s
✅ REPOSITORY checkov yes no no 41.42s
✅ REPOSITORY gitleaks yes no no 9.18s
✅ REPOSITORY git_diff yes no no 0.29s
✅ REPOSITORY secretlint yes no no 30.13s
✅ REPOSITORY syft yes no no 3.78s
✅ REPOSITORY trivy-sbom yes no no 9.38s
✅ REPOSITORY trufflehog yes no no 14.36s
✅ YAML prettier 11 0 0 0 0.55s
✅ YAML v8r 11 0 0 8.35s
✅ YAML yamllint 11 0 0 0.42s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 2, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant