Skip to content

Reject boolean PyTorch creation shapes#3717

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-creation-bool-shapes-2
Open

Reject boolean PyTorch creation shapes#3717
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-creation-bool-shapes-2

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • reject bool-valued shape arguments in the PyTorch creation-helper compatibility wrapper
  • keep the public PyTorch backend synchronized with the raw backend helpers
  • add regression coverage for public PyTorch and raw PyTorch imports with the NumPy public backend

Bug fixed

The PyTorch creation compatibility path used the scalar index protocol for shapes, which allowed bool values to be treated as integer dimensions. NumPy rejects bool shape dimensions, so this diverged from the NumPy-style backend contract.

Testing

  • Not run locally: this execution environment cannot clone/install the full repository from GitHub here.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 81.28s
✅ JSON prettier 7 0 0 0 0.8s
✅ JSON v8r 7 0 0 4.61s
✅ MARKDOWN markdownlint 68 0 0 0 2.04s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 1.17s
✅ PYTHON black 1206 37 0 0 71.45s
✅ PYTHON isort 1206 71 0 0 5.4s
✅ REPOSITORY checkov yes no no 49.57s
✅ REPOSITORY gitleaks yes no no 10.31s
✅ REPOSITORY git_diff yes no no 0.17s
✅ REPOSITORY secretlint yes no no 36.81s
✅ REPOSITORY syft yes no no 4.44s
✅ REPOSITORY trivy-sbom yes no no 12.19s
✅ REPOSITORY trufflehog yes no no 23.08s
✅ YAML prettier 11 0 0 0 0.77s
✅ YAML v8r 11 0 0 12.33s
✅ YAML yamllint 11 0 0 0.6s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant