Allow passing arguments with normal arguments#6
Open
EXtremeExploit wants to merge 1 commit into
Open
Conversation
a2af261 to
cd09287
Compare
cd09287 to
252f092
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All arguments given after the declaration of what image to use, are passed as arguments to the entrypoint, so arguments can be passed like if they were going to wf_server directly instead of messing with " and escaping characters
Allows passing arguments like this:
docker run \ -v=wf:/home/warfork/server \ -v=/path/to/wflogs:/home/warfork/.local/share/warfork-2.1/basewf \ --net=host \ gelmo/warfork-docker +sv_hostname "Meow meow" +sv_port 67This helps a lot with arguments or cvars that need to be enclosed in " or ', or both at the same time
Also changes it to an ENTRYPOINT, so that arguments for it can be easily added within compose, and using ENTRYPOINT and CMD (not used) the intended way (entrypoint for the binary if its static, and CMD for arguments or for any other binary)
It still allows using the tv variant entrypoint with --entrypoint and with the entrypoint key in compose
After this it would be possible to get rid of WF_PARAMS too