Skip to content

fix: Fix listbox row animation reliability to be opt-in and frame rate independent#530

Open
MrS-ibra wants to merge 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
MrS-ibra:fix/listbox-row-anim-2
Open

fix: Fix listbox row animation reliability to be opt-in and frame rate independent#530
MrS-ibra wants to merge 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
MrS-ibra:fix/listbox-row-anim-2

Conversation

@MrS-ibra

Copy link
Copy Markdown
Member

This PR is a proper reimplementation for listbox entry animations we introduced in #239
The original implementation lived in LobbyUtils.cpp and only worked for specific and sometimes unintended listboxes. This refactor moves all animation logic we introduced into GadgetListBox.cpp where it is available to any listbox in the game, and makes it opt-in via SetListBoxRowAnimMode so only intended listboxes would animate their entry rows.

fixes:

  • Animation is now frame rate independent.
  • Listboxes that were not intended to animate no longer do so since only listboxes that we opt in would animate now.
  • Fixes the issue where rows stopped animating after reopening a listbox because stale animation state from previous sessions was being reused.

Other listboxes can be opted in by calling SetListBoxRowAnimMode at init time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant