Fix nil panic when kicking a link-dead session at login#622
Open
pruuk wants to merge 1 commit into
Open
Conversation
users.GetByUserId returns nil when the target session has already been removed from the active user map (e.g. link-dead cleanup between the kick prompt and the answer). Answering "y" to the kick prompt then dereferenced a nil UserRecord and crashed the server. Skip the kick when there is no live session and proceed with the normal login flow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR kit 1 — login-kick nil panic
Branch
fix/login-kick-nil-panicis already pushed to GoMudEngine/GoMud.Open the PR here:
master...fix/login-kick-nil-panic
PR title
PR body (matches the repo's PR template: Description + Changes)