Feat: add AddBlock method for adding block rows to Panels#630
Open
ccubed wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This is my implementation of the requested Block rows in #624 for the panel system. This allows you to display a block of text without a label. This allows you to do something like this:
And produce a panel that looks like this:
Changes
Provide a bullet point list of noteworthy changes in this Pull Request:
Blockboolean to PanelRow StructAddBlockfunction to add a Block RowrenderSingleBlockColumnLinesfunction to render block content correctlypanelInnerWidthto calculate block widths correctlyrenderCellContentto render block cells correctlyrenderSingleColumnLinesto redirect Block Rows to a new function (It doesn't need to be a new function, but I thought it was eaiser to read this way)TestRenderPanel_BlockRowthat ensures we render blocks correctly and within visible width constraints. It also ensures we ignore labels even if provided.Small Note
This does not contain the fixes for #628 because I wanted to separate the new feature from the bug fix, but I've tested they can both be merged automatically.