Find/replace in the active file and follow workspace symlinks

[GordonBeeming]

Summary

• Find in File is now find-and-replace. Cmd+F opens the app's own overlay instead of CodeMirror's panel, the arrow keys cycle matches and select each one in the editor with focus kept in the field, the results preview scrolls to follow the active match, and Cmd+R reveals a replace row with Replace and Replace All. Select All and the other standard edit keybinds now work in every textbox after wiring the macOS Edit menu's Select All item.
• The editor follows symlinks instead of rejecting them. A target inside the workspace opens and expands silently; one that escapes the workspace prompts first with Cancel / Trust once / Trust for workspace, where "once" lasts the session and "workspace" is persisted. Symlinked entries are marked in the tree, with a distinct icon and the target path when they point outside the workspace. Renaming or deleting a symlink only affects the link, never its target.

Test plan

• cargo test (159 pass) — new tests cover symlink resolution, logical-path listing for symlinked dirs, FileEntry symlink facts, and rename/delete of a symlink touching only the link
• npm test (307 pass) — new tests cover the find/replace keyboard flow, the result-window math, and the external-symlink trust prompt
• npm run build, npm run menu:check
• Manual: an in-workspace symlink (.claude/skills) opens and expands; an external symlink shows the trust prompt and follows after trust; Cmd+F find/replace works with the editor focused

🤖 Generated with Claude Code

https://claude.ai/code/session_014F5fq81S92ZZi59Xp9aGue

[gemini-code-assist]

Code Review

This pull request introduces support for handling external symbolic links with user trust prompts, alongside a new find-and-replace feature in the active file. The review feedback highlights several critical improvements: first, the workspace root path should be canonicalized before performing starts_with checks in workspace.rs to ensure consistent path comparisons; second, multiple document changes dispatched to CodeMirror 6 in EditorPane.tsx must be sorted and deduplicated to prevent runtime crashes; and finally, side effects in App.tsx should be moved out of the React state updater callback to avoid anti-patterns.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[Copilot]

Pull request overview

This PR enhances the IDE’s in-editor search UX by adding a first-party Find/Replace overlay for the active file, and improves workspace filesystem support by following symlinks with a user trust gate when targets escape the workspace root.

Changes:

• Add Find/Replace-in-active-file overlay (Cmd/Ctrl+F, Cmd/Ctrl+R) with match navigation, replace/replace-all commands, and preview-window scrolling.
• Follow workspace symlinks (including directory listing) with metadata surfaced to the UI and a trust prompt for external targets (session/workspace trust).
• Extend the Tauri/HTTP API surface and persisted UI state to carry symlink/trust metadata and allow external symlink traversal when permitted.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/tauri.ts	Extends frontend API wrappers and types for symlink metadata and external-symlink allowance.
src/tauri.test.ts	Updates API transport tests to assert the new allowExternalSymlinks argument is forwarded.
src/styles.css	Adds styling for symlink markers in the tree and the new Find/Replace overlay layout/actions.
src/EditorPane.tsx	Removes CodeMirror search keymap and adds editor-side replace application + match-range reveal selection.
src/editorCommands.ts	Introduces replace-related editor commands and payload types for match-targeted edits.
src/currentFileSearch.ts	Adds currentFileResultWindow helper for scrolling the match preview window with the active match.
src/currentFileSearch.test.ts	Adds tests for the new preview-window behavior and edge cases.
src/App.tsx	Implements Find/Replace overlay behavior, match navigation, replace command dispatch, and external symlink trust prompt/persistence.
src/App.test.tsx	Adds tests for keyboard-driven find/replace flow and external symlink trust prompt behavior; updates existing expectations for new args.
src-tauri/src/workspace.rs	Adds symlink metadata to FileEntry, enables safe symlink following with external trust gating, and ensures rename/delete affect links not targets.
src-tauri/src/workspace_index.rs	Ensures background indexing never follows external symlinks and populates default symlink metadata in indexed entries.
src-tauri/src/lib.rs	Threads allow_external_symlinks through Tauri commands and persists trust_external_symlinks; wires macOS Edit menu Select All.
src-tauri/src/http_server.rs	Keeps hosted API behavior consistent with “never follow external symlinks” for background/hosted endpoints.
src-tauri/src/git_attribution.rs	Updates path resolution for attribution with the new symlink-aware resolver + revised error reason.

Comments suppressed due to low confidence (1)

src/tauri.ts:493

• allowExternalSymlinks is only included in invokeArgs, but hosted mode uses the request URL and doesn't serialize invokeArgs. As a result, hosted read_file requests cannot opt into following external symlinks after trust is granted.

  const params = new URLSearchParams({ path });
  if (maxOpenBytes !== undefined) {
    params.set("maxOpenBytes", String(maxOpenBytes));
  }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57a2adc592

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.