feat(mods): 实现模组列表导出功能 by zkitefly · Pull Request #6233 · HMCL-dev/HMCL

zkitefly · 2026-06-26T17:53:34Z

支持CSV和JSON格式，可自定义导出字段

要在模组列表选择要导出的项，然后就有导出清单按钮

close #6158

实现模组列表导出功能，支持CSV和JSON格式，可自定义导出字段

3gf8jv4dv

默认窗口大小下，对话框高度几乎撑满窗口了。要不限制一下？

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Minecraft269 · 2026-06-27T02:10:11Z

解决一下CheckStyle?

Minecraft269 · 2026-06-27T02:10:19Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a feature to export the mod list to CSV or JSON format, including a UI dialog for selecting export formats and fields, and backend logic for generating the files and computing SHA1/SHA512 hashes. The review feedback highlights three critical improvements: offloading the export and hash computation to a background thread to prevent blocking the JavaFX UI thread, adding defensive null checks when retrieving mod field values to avoid potential NullPointerExceptions, and localizing the hardcoded English labels in the export dialog to support proper internationalization.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

ChouChiu · 2026-06-27T04:12:14Z

会不会考虑做成 Prsim 那样，导出的格式更多一点，还能自定义

Minecraft269 · 2026-06-27T04:20:28Z

话说支不支持mcmod的格式? (方便整合包作者)

zkitefly · 2026-06-27T04:30:19Z

话说支不支持mcmod的格式? (方便整合包作者)

具体是什么格式

…o modlist-output

Minecraft269 · 2026-06-27T04:42:55Z

话说支不支持mcmod的格式? (方便整合包作者)

具体是什么格式

https://www.mcmod.cn/class/2995.html https://bbs.mcmod.cn/thread-21260-1-1.html 应该是这种格式吧

zkitefly · 2026-06-27T07:02:57Z

会不会考虑做成 Prsim 那样，导出的格式更多一点，还能自定义

已支持

Minecraft269 · 2026-06-27T09:23:51Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a feature to export the mod list to CSV, JSON, or custom text formats asynchronously, complete with a configuration dialog in the UI and corresponding localization updates. The review feedback highlights several key areas for improvement: addressing thread-safety issues by replacing the remoteModInfoCache's HashMap with a ConcurrentHashMap, preventing potential NullPointerExceptions by adding null checks for fetched remote addons, improving error dialogs when exception.getMessage() is null, refactoring duplicated emoji-filtering logic, and resolving performance bottlenecks caused by sequential network requests during bulk exports.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

当异常无详细信息时，使用异常类全名代替空提示，让用户能获取足够的错误信息

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

zkitefly · 2026-06-28T04:34:55Z

话说支不支持mcmod的格式? (方便整合包作者)

具体是什么格式

https://www.mcmod.cn/class/2995.html https://bbs.mcmod.cn/thread-21260-1-1.html 应该是这种格式吧

这里的网盘连接过期了，找不到源文件，也没有讲是啥格式（

3gf8jv4dv · 2026-06-28T04:45:01Z

这里的网盘连接过期了，找不到源文件，也没有讲是啥格式（

我看了下，bbs.mcmod.cn 链接里说是用 https://www.mcmod.cn/class/2995.html 这个模组。

用这个模组导出的结构，和这个 PR JSON 格式的一致。

zkitefly · 2026-07-16T05:51:20Z

CC?

Minecraft269 · 2026-07-16T06:12:09Z

CC?

自行 /gemini review即可(在7.16之前(诶不对击退就是7.16 所以今天是最后一天了)) 修正是7.17

Minecraft269 · 2026-07-16T06:12:16Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a feature to export the mod list to CSV, JSON, or custom text formats asynchronously, complete with a configuration dialog, parallel prefetching of metadata, and localization support. The review feedback identifies a thread-safety issue where a plain integer is incremented concurrently, which should be refactored to an AtomicInteger. Additionally, it is recommended to remove the manual System.gc() call to prevent potential UI stuttering during garbage collection.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

…java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

zkitefly · 2026-07-16T06:32:43Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a feature to export the mod list to CSV, JSON, or a custom template format asynchronously, along with UI dialogs and internationalization support. The review feedback highlights several critical areas for improvement: resolving potential thread starvation deadlocks and performance bottlenecks caused by nested blocking joins in parallel prefetching tasks, simplifying remote mod info retrieval by fetching sources sequentially, handling custom template placeholder prefetching, clearing caches between exports to prevent stale data, and improving the user experience by removing redundant progress updates during the final export phase.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

zkitefly · 2026-07-16T07:59:05Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a feature to export the mod list to CSV, JSON, or custom text formats asynchronously. It adds an export dialog to the UI, supports fetching remote mod metadata from CurseForge and Modrinth, caches file hashes, and extracts emoji-filtering logic into a reusable utility method. The review comments identify two important issues: first, a concurrency risk where shared cache maps on the page instance are cleared and accessed by concurrent export tasks; second, a thread-blocking issue where acquiring semaphores inside thread pool tasks can lead to thread starvation. Both comments provide highly actionable suggestions to improve thread safety and resource utilization.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

zkitefly · 2026-07-16T09:36:30Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces an asynchronous mod list export feature supporting CSV, JSON, and custom text formats, complete with a configuration dialog, localization keys, and caching for file hashes and remote metadata. The review feedback highlights opportunities to improve efficiency and maintainability: first, by avoiding clearing caches at the start of every export to preserve data across consecutive runs; second, by merging switch cases in getFieldValue to prevent redundant getRemoteModInfo calls; and third, by refactoring the checkbox creation in showExportDialog to eliminate repetitive code and adhere to DRY principles.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-07-16T09:40:54Z

+        remoteModInfoCache.clear();
+        sha1Cache.clear();
+        sha512Cache.clear();


在 exportMods 方法的开头，每次导出都会清空 remoteModInfoCache、sha1Cache 和 sha512Cache。这会导致在连续导出（例如，用户第一次导出后发现缺少字段，然后立即进行第二次导出）或重试失败的导出时，所有缓存数据都被清除，即使是已经成功获取的数据也需要重新获取，降低了效率。

考虑到重试逻辑中已经有了针对性地移除失败缓存的逻辑 (task.getFailedModPaths().forEach(remoteModInfoCache::remove))，建议移除此处的全局清空缓存操作，以提升用户体验和性能。例如，可以提供一个手动刷新缓存的按钮，而不是在每次导出时自动清空。

gemini-code-assist · 2026-07-16T09:40:54Z

+            case "curseForgeUrl" -> {
+                RemoteModInfo remoteInfo = getRemoteModInfo(mod);
+                yield remoteInfo.curseForgeUrl;
+            }
+            case "curseForgeFileUrl" -> {
+                RemoteModInfo remoteInfo = getRemoteModInfo(mod);
+                yield remoteInfo.curseForgeFileUrl;
+            }
+            case "curseForgeDownloadPage" -> {
+                RemoteModInfo remoteInfo = getRemoteModInfo(mod);
+                yield remoteInfo.curseForgeDownloadPage;
+            }
+            case "modrinthUrl" -> {
+                RemoteModInfo remoteInfo = getRemoteModInfo(mod);
+                yield remoteInfo.modrinthUrl;
+            }
+            case "modrinthFileUrl" -> {
+                RemoteModInfo remoteInfo = getRemoteModInfo(mod);
+                yield remoteInfo.modrinthFileUrl;
+            }


在 getFieldValue 方法中，获取 curseForgeUrl、curseForgeFileUrl 等多个远程信息字段时，每个 case 分支都重复调用了 getRemoteModInfo(mod)。这使得代码显得冗余，不易维护。

建议将这些 case 合并，一次性获取 RemoteModInfo 对象，然后根据 field 返回对应的属性值。这样可以使代码更简洁，也为后续优化（如在 getFieldValues 中缓存 RemoteModInfo）打下基础。

case "curseForgeUrl", "curseForgeFileUrl", "curseForgeDownloadPage", "modrinthUrl", "modrinthFileUrl" -> { RemoteModInfo remoteInfo = getRemoteModInfo(mod); yield switch (field) { case "curseForgeUrl" -> remoteInfo.curseForgeUrl; case "curseForgeFileUrl" -> remoteInfo.curseForgeFileUrl; case "curseForgeDownloadPage" -> remoteInfo.curseForgeDownloadPage; case "modrinthUrl" -> remoteInfo.modrinthUrl; case "modrinthFileUrl" -> remoteInfo.modrinthFileUrl; default -> ""; // Should not happen }; }

zkitefly · 2026-07-16T10:02:58Z

@Glavo CC?

feat(mods): add mod list export function

ddfa3f1

实现模组列表导出功能，支持CSV和JSON格式，可自定义导出字段

3gf8jv4dv reviewed Jun 26, 2026

View reviewed changes

Comment thread HMCL/src/main/resources/assets/lang/I18N_zh.properties Outdated

Comment thread HMCL/src/main/resources/assets/lang/I18N_zh.properties Outdated

Comment thread HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Outdated

zkitefly and others added 3 commits June 27, 2026 09:56

Update HMCL/src/main/resources/assets/lang/I18N_zh.properties

1a0259b

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update HMCL/src/main/resources/assets/lang/I18N_zh.properties

9054ec4

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

3e6e68e

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

gemini-code-assist Bot reviewed Jun 27, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java Outdated

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java Outdated

zkitefly added 2 commits June 27, 2026 10:23

style(ModListPage): 调整模组列表页面滚动面板配置

1cead35

style(ui/versions): 移除未使用的导入包

bbb1031

fix(mod export): 修复模组导出功能并添加导出中提示

dc42073

Merge branch 'modlist-output' of https://github.com/zkitefly/HMCL int…

384017f

…o modlist-output

zkitefly added 3 commits June 27, 2026 12:47

feat(mods export): 为模组导出功能添加多语言字段选项

7b80f5a

chore(i18n): 移除模组导出的SHA哈希字段国际化

a8021d6

feat(mods): 新增模组列表自定义文本导出功能

b75e3e7

zkitefly added 3 commits June 27, 2026 15:35

feat(mods.export): 添加 CurseForge 和 Modrinth 的文件 URL 和项目 URL 导出

cc16511

feat(mods.export): 添加 CurseForge 网页文件 URL

ca957cf

fix

7043267

gemini-code-assist Bot reviewed Jun 27, 2026

View reviewed changes

zkitefly added 5 commits June 27, 2026 17:39

fix

2742700

perf(ModListPage): 优化模组导出性能，添加并行预取与缓存

700cbc2

refactor(mod export): 重构模组导出逻辑并添加进度提示

000af29

refactor(utils): 提取表情移除逻辑到StringUtils

2baa766

fix(ModListPage): 优化模组导出失败时的错误提示展示

33ff97a

当异常无详细信息时，使用异常类全名代替空提示，让用户能获取足够的错误信息

zkitefly and others added 2 commits June 28, 2026 09:01

Update HMCL/src/main/resources/assets/lang/I18N.properties

bfd6742

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

refactor(ModListPage): 调整导出CSV的字段顺序并优化字段处理

adc9b3b

3gf8jv4dv mentioned this pull request Jun 29, 2026

[Feature] 实例的模组列表区添加「导出为列表」功能 UNIkeEN/SJMCL#1805

Open

zkitefly added 3 commits July 16, 2026 01:17

Merge remote-tracking branch 'upstream/main' into modlist-output

b0d6766

feat(mods.export): add network error retry prompt for mod export

97b5e91

fix(ModListPage): 修复导出模组时字段顺序丢失的问题

418ac06

gemini-code-assist Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java Outdated

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java Outdated

zkitefly and others added 2 commits July 16, 2026 14:19

Update HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.…

dd66fe6

…java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update ModListPage.java

293df31

gemini-code-assist Bot reviewed Jul 16, 2026

View reviewed changes

zkitefly added 3 commits July 16, 2026 15:02

Update ModListPage.java

74d0678

Update ModListPage.java

3b76e6e

update

f009277

gemini-code-assist Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java

zkitefly added 2 commits July 16, 2026 16:55

refactor(ModListPage): 调整信号量获取和释放的位置

670a9fd

fix

72c7b84

gemini-code-assist Bot reviewed Jul 16, 2026

View reviewed changes

refactor(mod export): 重构模组导出配置界面，简化代码逻辑

6542ab6

3gf8jv4dv reviewed Jul 16, 2026

View reviewed changes

Comment thread HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Outdated

update i18n id

4b0c389

github-actions Bot added the 500+ label Jul 17, 2026

Uh oh!

Conversation

zkitefly commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

3gf8jv4dv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Minecraft269 commented Jun 27, 2026

Uh oh!

Minecraft269 commented Jun 27, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChouChiu commented Jun 27, 2026

Uh oh!

Minecraft269 commented Jun 27, 2026

Uh oh!

zkitefly commented Jun 27, 2026

Uh oh!

Minecraft269 commented Jun 27, 2026

Uh oh!

zkitefly commented Jun 27, 2026

Uh oh!

Minecraft269 commented Jun 27, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zkitefly commented Jun 28, 2026

Uh oh!

3gf8jv4dv commented Jun 28, 2026

Uh oh!

zkitefly commented Jul 16, 2026

Uh oh!

Minecraft269 commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Minecraft269 commented Jul 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

zkitefly commented Jul 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zkitefly commented Jul 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

zkitefly commented Jul 16, 2026

Uh oh!

zkitefly commented Jun 26, 2026 •

edited

Loading

Minecraft269 commented Jul 16, 2026 •

edited

Loading