[Bugfix] 修复导出整合包文件选择界面UI线程阻塞#6363
Open
ToobLac wants to merge 1 commit into
Open
Conversation
ToobLac
marked this pull request as ready for review
July 10, 2026 10:12
Contributor
|
我感觉可以把文件树展开变成惰性加载，现在太卡是主要因为每次进入这个页面都会创建完整的文件树列表项控件（并且可能造成大量内存占用），感觉这样还是有点治标不治本 |
Contributor
Author
那展开节点的时候还得卡一下，手感不好啊。而且本来加载的过程根本不读取文件内容，只看文件名以及是否为目录，占用和耗时并不是很大 |
Glavo
reviewed
Jul 16, 2026
Glavo
left a comment
Glavo
left a comment
Member
There was a problem hiding this comment.
本审查建议由 GPT-5.6 Sol 生成
已将具体审查建议标注在对应代码行。
| setMargin(spinnerPane, new Insets(10, 10, 5, 10)); | ||
| this.setCenter(spinnerPane); | ||
|
|
||
| spinnerPane.setLoading(true); |
Member
There was a problem hiding this comment.
当遍历期间出现 UncheckedIOException 等异常时，CompletableFuture 会异常完成，导致 thenAcceptAsync 完全不执行；此时 spinnerPane 永远保持加载状态，“下一步”也始终禁用，且异常不会被记录或展示。应添加异常完成处理，在 JavaFX 线程中结束加载状态并向用户报告或允许重试。
| @@ -176,6 +189,7 @@ public void cleanup(SettingsMap settings) { | |||
| } | |||
|
|
|||
Member
There was a problem hiding this comment.
当游戏目录不存在、为空或所有内容均被过滤时，getTreeItem 会返回 null；加载结束后按钮会重新启用，但此处直接返回，使用户点击“下一步”没有任何反应。修改前 getFilesNeeded(null, ...) 会生成空列表并继续调用 controller.onFinish()，因此这是空目录场景下的新回归。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6354
现在在 IO 线程上进行加载，加载完成后再显示并开放“下一步”按钮