Fix #6298: 🐛 Allow Enter key selection when selected is null#6300
Open
balajis-qb wants to merge 1 commit into
Open
Fix #6298: 🐛 Allow Enter key selection when selected is null#6300balajis-qb wants to merge 1 commit into
balajis-qb wants to merge 1 commit into
Conversation
YearPicker prevented selection via Enter key when `selected` was null due to an early return in `onYearKeyDown`. This caused inconsistent behavior compared to: - Mouse selection (which worked) - Other picker modes (day/month) Removed the unnecessary guard and allowed selection based on the currently focused/preselected year. Also updated tests that incorrectly enforced the previous behavior. Closes Hacker0x01#6298
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6300 +/- ##
==========================================
+ Coverage 99.29% 99.31% +0.02%
==========================================
Files 30 30
Lines 3822 3820 -2
Branches 1648 1664 +16
==========================================
- Hits 3795 3794 -1
+ Misses 26 25 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #6298
Problem
In YearPicker (
showYearPicker), pressing Enter does not select a year whenselectedisnullorundefined.This is caused by an early return in
onYearKeyDown(src/year.tsx):This prevents keyboard-based selection entirely when no initial value is set.
The behavior is inconsistent with:
Changes
selected == nullguard from Enter key handlingselectedis nullBehavior Changes
selectedis initially nullselectedare updatedContribution checklist