fix(asm): drop null example literals crashing Spectral lint#50
Merged
Conversation
The scan.failed webhook example (merged in #21) included `label: null` and `completed_at: null` under the OAS 3.1 array-form nullable schema introduced earlier — Spectral (spectral-cli 6.16.0, as pinned) throws "Cannot read properties of null (reading 'enum')" on that combination. Both fields are optional/nullable, so omitting them is equally valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While merging the open-PR backlog, the
scan.failedwebhook example (from #21) landed withlabel: nullandcompleted_at: nullunder the OAS 3.1 array-form nullable schema (type: [string, 'null'], from the earlier nullable-fix merge). Spectral (spectral-cli 6.16.0, as pinned in CI) throwsCannot read properties of null (reading 'enum')on that specific combination — a real lint crash, not a false positive.Both fields are optional and nullable, so omitting them from the example is equally valid and avoids the crash. Verified
spectral lint asm/openapi.yaml --ruleset .spectral.yaml --fail-severity errornow passes cleanly.Test plan
spectral lint asm/openapi.yaml --ruleset .spectral.yaml --fail-severity error→ 0 errors🤖 Generated with Claude Code
Generated by Claude Code