Update footer links and copyright notice in ApplicationController#283
Merged
Conversation
One of the few things that stuck in my head when we met with an NHS UX designer was that the links should "say what they are doing". This is the NHS design system footer. Perhaps we could have a similar sort of idea with:
Maintained by Health Data Insight CIC. If you've got a question or want to feed back, [get in touch](GitHub link??). |
Make the dummy app footer say what its links do (Download the RubyGem, View the source on GitHub, Get in touch) and show a maintainer copyright line. Add three symbol-based toggles to the Branded concern so services can hide GOV.UK Crown-specific footer chrome that only Crown bodies should display: govuk_footer_crown, govuk_footer_licence and govuk_footer_copyright_logo (each defaults to visible; set to :hidden to opt out). When the copyright crest is hidden, the notice renders in govuk-footer__meta-custom so it stays aligned. The dummy app hides all three. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
|
timgentry
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove NHS England copyright from the dummy app
Why?
It's not their copyright
How?
Replace NHSE footer links and copyright with HDI ones
Testing?
Eyeballed in the browser
Screenshots (optional)
NHS:
GOV:
Anything Else?
No