Skip to content

Fix ArgumentError after invoking setter #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ur5us merged 3 commits into from
Jun 4, 2026
Merged

Fix ArgumentError after invoking setter #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
755ba96
Fix ArgumentError after invoking setter
ur5us Jun 3, 2026
ad08bf7
Add spec for Resource#[]= method
ur5us Jun 3, 2026
e9e2445
Address PR feedback
ur5us Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/hubspot/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ def [](name)
@changes[name] || @properties.dig(name, 'value')
end

def []=(name, value)
@changes[name] = value unless @changes[name] == value
end

def reload
raise(Hubspot::InvalidParams.new("Resource must have an ID")) if @id.nil?

Expand Down
12 changes: 12 additions & 0 deletions spec/lib/hubspot/resource_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@
end
end

describe '#[]=' do
let(:resource) { described_class.from_result({ properties: }) }
let(:properties) { { id: { 'value' => 1 }, firstname: { 'value' => 'John' }, lastname: { 'value' => 'Wayne' } } }

it 'stages a change to a property' do
resource[:firstname] = 'Jon'

expect(resource[:firstname]).to eq 'Jon'
expect(resource.changes).to include(firstname: 'Jon')
end
end

describe '#adding_accessors' do
describe 'getters' do
context 'using new' do
Expand Down